Update secp256k1 subtree to latest master #36203

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:update_secp_subtree changing 31 files +680 −404

fanquake commented at 9:57 AM on September 9, 2026: member
Primarily prompted by https://github.com/bitcoin-core/secp256k1/pull/1932, which came up here: #35301 (review). See https://github.com/bitcoin-core/secp256k1/issues/1930.

Includes:
DrahtBot commented at 9:57 AM on September 9, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36203.



Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers

ACK theStack, sedited

Concept ACK real-or-random

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.
fanquake commented at 9:57 AM on September 9, 2026: member

cc @theStack @real-or-random
real-or-random commented at 9:59 AM on September 9, 2026: contributor

Concept ACK
sedited approved
sedited commented at 11:45 AM on September 9, 2026: contributor

ACK 905a956810adf2ccce439650ea4bbaf763f59d3c
DrahtBot requested review from real-or-random on Sep 9, 2026
theStack approved
theStack commented at 12:27 PM on September 9, 2026: contributor

ACK 905a956810adf2ccce439650ea4bbaf763f59d3c

Verified against https://github.com/bitcoin-core/secp256k1/commit/3f6ee3e98950366c88253c82f00b3b48c58bbbec (I'm only seeing this PR now after having merged https://github.com/bitcoin-core/secp256k1/pull/1923, so "latest master" changed again, sorry. Happy to re-review if you want to update the subtree again, though the important one https://github.com/bitcoin-core/secp256k1/pull/1932 is in, so there is no strong need).

Type	Reviewers
ACK	theStack, sedited
Concept ACK	real-or-random

Squashed 'src/secp256k1/' changes from 687155df6b..a7f264373e

a7f264373e Merge bitcoin-core/secp256k1#1923: group: VERIFY input/output ge/gej/fe exhaustively
3f6ee3e989 Merge bitcoin-core/secp256k1#1931: tests: cover rejection of invalid plain seckey alongside a valid one
05f9289984 tests: silentpayments: cover rejection of invalid plain seckey alongside a valid one
978d3fa7f9 Merge bitcoin-core/secp256k1#1932: silentpayments: drop "empty key arrays must be NULL" requirement
ad3688d1e5 changelog: mention dropped NULL requirement for silentpayments key arrays
89e3a70662 silentpayments: drop "empty key arrays must be NULL" requirement
c36269ef95 group/refactor: Use constant expression for readability
031dbae659 group: Export secp256k1_ge_set_ge(j)_zinv properly in group.h
4f3bd158d5 group: Cover all input/output ge/gej/fe with VERIFY calls
0711443e6d group: Add missing FE_VERIFY checks on rzr outputs
1bd7492181 group: Remove redundant SECP256K1_GEJ_VERIFY
cddd125f72 group: Split functions into pre/post VERIFY and _impl
aa0af2fac4 Merge bitcoin-core/secp256k1#1928: tests: add coverage for exact-size DER signature serialization
500ccb60f7 tests: add coverage for exact-size DER signature serialization
a9a61831bd Merge bitcoin-core/secp256k1#1924: tests: add coverage for the DER long form length encoding
ddb1dfa770 tests: add coverage for the DER long form length encoding
1c8babcd6c Merge bitcoin-core/secp256k1#1922: field: Check that argument of _fe_set_int() is a constant
bae6b89a20 Merge bitcoin-core/secp256k1#1908: refactor: replace `_get_hash_context` with direct `->hash_ctx` access
f6d821db03 field: Fix typo in comment
1ce0066e60 field: Check that argument of _fe_set_int() is a constant
c8745f6b3a refactor: replace `_get_hash_context` with direct `->hash_ctx` access
3397f3cb28 Merge bitcoin-core/secp256k1#1878: field: correct `_fe_half` docs (output is not normalized, input requires magnitude <= 31)
86c7cbaf5a Merge bitcoin-core/secp256k1#1915: refactor: Move (de)ser helpers from musig and eckey to group
bfd40bd0ce refactor: Rename privkey to seckey in eckey helpers
d8ee6e6cf6 refactor: Move parsing helpers from musig to group
a37d7cc064 Merge bitcoin-core/secp256k1#1916: ecdh/ellswift: simplify seckey loading with `_scalar_set_b32_seckey`
3d69f4ce1c Merge bitcoin-core/secp256k1#1911: refactor: rename `ctx` param to `ecmult_gen_ctx` where applicable
c00dc81810 ecdh/ellswift: simplify seckey loading with `_scalar_set_b32_seckey`
81a5a7567d refactor: rename `ctx` param to `ecmult_gen_ctx` where applicable
2577fb1888 refactor: Move pubkey parsing and serialization from eckey to group
439278a649 Merge bitcoin-core/secp256k1#1910: scratch: reject sizes that overflow when added to header
3d4340d173 scratch: reject sizes that overflow when added to header
56e031a148 field: correct `_fe_half` docs (output is not normalized, input requires magnitude <= 31)

git-subtree-dir: src/secp256k1
git-subtree-split: a7f264373e5b187536c21e434f632b571b3ab178

da3401e50f

Update secp256k1 subtree to latest master ba9050ac9b
fanquake force-pushed on Sep 9, 2026
fanquake commented at 12:33 PM on September 9, 2026: member

after having merged https://github.com/bitcoin-core/secp256k1/pull/1923

No worries, pushed to pull that in too.
theStack approved
theStack commented at 12:48 PM on September 9, 2026: contributor

ACK ba9050ac9b359d7725bd2308431c0a4fd2fd38ed
DrahtBot requested review from sedited on Sep 9, 2026
real-or-random commented at 1:33 PM on September 9, 2026: contributor

Sorry, I saw the comments here only after I merged yet another PR in into libsecp256k1 master. But to be honest I don't think this should affect this PR here. Any of the tips is fine; let's maybe stick to https://github.com/bitcoin-core/secp256k1/pull/1923 here to get this PR merged.
sedited approved
sedited commented at 2:26 PM on September 9, 2026: contributor

Re-ACK ba9050ac9b359d7725bd2308431c0a4fd2fd38ed
sedited merged this on Sep 9, 2026
sedited closed this on Sep 9, 2026
fanquake deleted the branch on Sep 9, 2026

Contributors

Review Requested
real-or-random

Linked (view graph)

#35301 Silent Payments: Implement bip352 (take 2)

Update secp256k1 subtree to latest master #36203

Code Coverage & Benchmarks

Reviews