Now that we target macOS >= 14.0 and use macOS SDK 14.0, and no-longer use objc_msgSend, this can be removed. Was added in #16720.
build: drop use of `OBJC_OLD_DISPATCH_PROTOTYPES` #36206
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:drop_OBJC_OLD_DISPATCH_PROTOTYPES changing 1 files +0 −1-
fanquake commented at 1:02 PM on September 9, 2026: member
- DrahtBot added the label Build system on Sep 9, 2026
-
DrahtBot commented at 1:03 PM on September 9, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36206.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process.
Type Reviewers ACK willcl-ark Concept ACK hebasto If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- fanquake added the label macOS on Sep 9, 2026
- fanquake added the label Android on Sep 9, 2026
- fanquake removed the label Android on Sep 9, 2026
-
hebasto commented at 11:26 AM on September 10, 2026: member
Concept ACK.
Here is a related snippet from the Qt 6.8.4 codebase:
# Xcode 14's Clang will emit objc_msgSend stubs by default, which ld # from earlier Xcode versions will fail to understand when linking # against static libraries with these stubs. Disable the stubs explicitly, # for as long as we do support Xcode < 14. - fanquake force-pushed on Sep 11, 2026
- fanquake requested review from willcl-ark on Sep 14, 2026
-
59f7f3d07d
build: drop use of OBJC_OLD_DISPATCH_PROTOTYPES
Now that we target macOS >= 14.0 and use macOS SDK 14.0, and no-longer use objc_msgSend, this can be removed.
- fanquake force-pushed on Sep 16, 2026
- maflcko added the label DrahtBot Guix build requested on Sep 16, 2026
-
fanquake commented at 2:05 PM on September 16, 2026: member
Guix Build:
x86_64 9563fcb440a63886389ff9c480ceef147797d03565545ee5f52836af72d2dd50 guix-build-59f7f3d07d95/output/arm64-apple-darwin/SHA256SUMS.part f3d38f62c4e57fb5a1960d26408cc26fa45142d1710976a5ba34e46f4510f43c guix-build-59f7f3d07d95/output/arm64-apple-darwin/bitcoin-59f7f3d07d95-arm64-apple-darwin-codesigning.tar.gz 372818871a447b17df671756d63ec231e1cbb069f504184b51910d7bde022853 guix-build-59f7f3d07d95/output/arm64-apple-darwin/bitcoin-59f7f3d07d95-arm64-apple-darwin-unsigned.tar.gz 5937a8b22b43e92846f6d77aa68eee44a339678c169ef9615f9828f764a30c0b guix-build-59f7f3d07d95/output/arm64-apple-darwin/bitcoin-59f7f3d07d95-arm64-apple-darwin-unsigned.zip fcc723c484f7491f74b21aa0b95cad3c542411f66aafa971f83c931dc0899fc8 guix-build-59f7f3d07d95/output/dist-archive/bitcoin-59f7f3d07d95.tar.gz 87cfd971cad29007ac55aed0a32fda34942a618f0d9857c5d5efc53c7aca9ac1 guix-build-59f7f3d07d95/output/x86_64-apple-darwin/SHA256SUMS.part 2308d14ee2ea00f4a938908d18e337def2246091618c14e0131607c632996a57 guix-build-59f7f3d07d95/output/x86_64-apple-darwin/bitcoin-59f7f3d07d95-x86_64-apple-darwin-codesigning.tar.gz cad9997a879197adacebfd43c6ccced6451d2942adbe1a19b30d9c3df24d4d7c guix-build-59f7f3d07d95/output/x86_64-apple-darwin/bitcoin-59f7f3d07d95-x86_64-apple-darwin-unsigned.tar.gz 3e5d5bf5296ac4c6bf9a50b41e5f3e1655040fbd1487c9a27c62a473e5c74fe0 guix-build-59f7f3d07d95/output/x86_64-apple-darwin/bitcoin-59f7f3d07d95-x86_64-apple-darwin-unsigned.zip -
DrahtBot commented at 2:33 PM on September 18, 2026: contributor
<!--9cd9c72976c961c55c7acef8f6ba82cd-->
Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]
- DrahtBot removed the label DrahtBot Guix build requested on Sep 18, 2026
-
willcl-ark commented at 3:00 PM on September 18, 2026: member
x86_64 9563fcb440a63886389ff9c480ceef147797d03565545ee5f52836af72d2dd50 guix-build-59f7f3d07d95/output/arm64-apple-darwin/SHA256SUMS.part f3d38f62c4e57fb5a1960d26408cc26fa45142d1710976a5ba34e46f4510f43c guix-build-59f7f3d07d95/output/arm64-apple-darwin/bitcoin-59f7f3d07d95-arm64-apple-darwin-codesigning.tar.gz 372818871a447b17df671756d63ec231e1cbb069f504184b51910d7bde022853 guix-build-59f7f3d07d95/output/arm64-apple-darwin/bitcoin-59f7f3d07d95-arm64-apple-darwin-unsigned.tar.gz 5937a8b22b43e92846f6d77aa68eee44a339678c169ef9615f9828f764a30c0b guix-build-59f7f3d07d95/output/arm64-apple-darwin/bitcoin-59f7f3d07d95-arm64-apple-darwin-unsigned.zip fcc723c484f7491f74b21aa0b95cad3c542411f66aafa971f83c931dc0899fc8 guix-build-59f7f3d07d95/output/dist-archive/bitcoin-59f7f3d07d95.tar.gz 87cfd971cad29007ac55aed0a32fda34942a618f0d9857c5d5efc53c7aca9ac1 guix-build-59f7f3d07d95/output/x86_64-apple-darwin/SHA256SUMS.part 2308d14ee2ea00f4a938908d18e337def2246091618c14e0131607c632996a57 guix-build-59f7f3d07d95/output/x86_64-apple-darwin/bitcoin-59f7f3d07d95-x86_64-apple-darwin-codesigning.tar.gz cad9997a879197adacebfd43c6ccced6451d2942adbe1a19b30d9c3df24d4d7c guix-build-59f7f3d07d95/output/x86_64-apple-darwin/bitcoin-59f7f3d07d95-x86_64-apple-darwin-unsigned.tar.gz 3e5d5bf5296ac4c6bf9a50b41e5f3e1655040fbd1487c9a27c62a473e5c74fe0 guix-build-59f7f3d07d95/output/x86_64-apple-darwin/bitcoin-59f7f3d07d95-x86_64-apple-darwin-unsigned.zip - willcl-ark approved
-
willcl-ark commented at 3:49 PM on September 18, 2026: member
ACK 59f7f3d07d9556fa2e9df2f39d8b9057ca87fdc2
Built and ran/tested the Gui on MacOS, along with a Darwin guix build.
- DrahtBot requested review from hebasto on Sep 18, 2026
- fanquake merged this on Sep 19, 2026
- fanquake closed this on Sep 19, 2026
- fanquake deleted the branch on Sep 19, 2026
