test: cover cluster limits during reorgs #36214

pull yuvicc wants to merge 1 commits into bitcoin:master from yuvicc:2026-7-add_reorg_test_cluster_mempoool changing 1 files +233 −0
  1. yuvicc commented at 4:10 AM on September 10, 2026: contributor

    This PR adds functional test coverage for cluster-limit handling during reorgs.

    Transactions resurrected from disconnected blocks are added before their existing mempool children are linked in the transaction graph. Once those dependencies are restored, oversized clusters must be trimmed back within their configured count and size limits.

  2. test: cover cluster limits during reorgs f396df91a7
  3. DrahtBot added the label Tests on Sep 10, 2026
  4. DrahtBot commented at 4:11 AM on September 10, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36214.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

    LLM Linter (✨ experimental)

    Possible typos and grammar issues:

    • the i'th one spending the (i-1)'th -> the i-th one spending the (i-1)-th [ordinal typo]

    <sup>2026-09-10 04:11:16</sup>

  5. fanquake commented at 8:56 AM on September 10, 2026: member
  6. instagibbs commented at 12:32 PM on September 10, 2026: member

    I think the only thing this test adds over test_chainlimits_exceeded and transaction_graph_test is testing the pre-existing mempool children are added back in to the clusters. Thoughts?

  7. yuvicc commented at 1:21 PM on September 10, 2026: contributor

    I think the only thing this test adds over test_chainlimits_exceeded and transaction_graph_test is testing the pre-existing mempool children are added back in to the clusters.

    Agree, transaction_graph_test covers reconnecting existing children. These tests cover clusters that become oversized only after reconnecting existing children, exercising Trim() for count, size, and merged clusters.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-20 21:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me