Running CLI utilities such as sha256sum on the encoded asmap blob, and then grepping for the outputted hash in the bitcoind debug.log was unsuccessful.
Inspired by #36201 (comment) + #36201#pullrequestreview-5158109401
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36215.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
The functional test needs an update, you should squash this into one commit so it doesn't have to be changed twice.
1700 | @@ -1701,7 +1701,7 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info) 1701 | return false; 1702 | #endif 1703 | } 1704 | - LogInfo("Using asmap version %s for IP bucketing", asmap_version.ToString()); 1705 | + LogInfo("Using asmap version %s for IP bucketing", HexStr(std::span{asmap_version.data(), asmap_version.size()}));
Does the span really need to be explicitly constructed here? HexStr(asmap_version) should just work afaict.
* Change version from double to single SHA256
This invalidates serialized AddrMan data which forces re-bucketing.
* Avoid reversing byte order for ASMap version in log
Makes it easier to match it with externally computed hashes of the encoded file.
Sorry for the incomplete initial state, latest push addresses the issues so far.
