[31.x] More Backports #36221

pull fanquake wants to merge 2 commits into bitcoin:31.x from fanquake:even_more_31_x_backports changing 2 files +5 −1
  1. fanquake commented at 4:07 PM on September 10, 2026: member

    Backports:

  2. build: avoid pipe2 on Darwin (for now)
    macOS 27 will support pipe2 at runtime, and Xcode 27 (and Command Line
    Tools) support it at compile time. This means a macOS < 27 system will
    detect support for pipe2, but then binaries will crash at runtime, as
    pipe2 is not available.
    
    Just avoid pipe2 on macOS for now, and continue using pipe. Note that
    the compilation also produces availability warnings, and this will need
    to be backported.
    
    Github-Pull: #36218
    Rebased-From: 9c7748315d3124d1abe6a4606743cd9274beee66
    233b120632
  3. DrahtBot added the label Backport on Sep 10, 2026
  4. DrahtBot commented at 4:07 PM on September 10, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36221.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK hebasto

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. hebasto approved
  6. hebasto commented at 4:26 PM on September 10, 2026: member

    ACK 1cc9ed38e45d85f27c2a527c929738420eb3725a.

  7. fanquake added this to the milestone 31.2 on Sep 10, 2026
  8. doc: update release notes for v31.x 475a98e961
  9. in doc/release-notes.md:91 in 1cc9ed38e4
      87 | @@ -88,6 +88,7 @@ Notable changes
      88 |  ### Build
      89 |  
      90 |  - #35769 depends, zeromq: Apply upstream patch
      91 | +- #36218 build: avoid pipe2 on Darwin (for now) - #36218
    


    hebasto commented at 4:59 PM on September 10, 2026:

    Duplicated "#36218"?

  10. fanquake force-pushed on Sep 11, 2026
  11. hebasto approved
  12. hebasto commented at 9:51 AM on September 11, 2026: member

    re-ACK 475a98e9617c23b36a8fd02b315c0aaf03d5f88b.

  13. fanquake merged this on Sep 11, 2026
  14. fanquake closed this on Sep 11, 2026

  15. fanquake deleted the branch on Sep 11, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-15 17:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me