[29.x] More Backports #36223

pull fanquake wants to merge 2 commits into bitcoin:29.x from fanquake:even_more_29_x_backports changing 2 files +8 −1
  1. fanquake commented at 4:48 PM on September 10, 2026: member

    Backports:

  2. build: avoid pipe2 on Darwin (for now)
    macOS 27 will support pipe2 at runtime, and Xcode 27 (and Command Line
    Tools) support it at compile time. This means a macOS < 27 system will
    detect support for pipe2, but then binaries will crash at runtime, as
    pipe2 is not available.
    
    Just avoid pipe2 on macOS for now, and continue using pipe. Note that
    the compilation also produces availability warnings, and this will need
    to be backported.
    
    Github-Pull: #36218
    Rebased-From: 9c7748315d3124d1abe6a4606743cd9274beee66
    7265ca9bba
  3. DrahtBot added the label Backport on Sep 10, 2026
  4. DrahtBot commented at 4:48 PM on September 10, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36223.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK hebasto

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. in doc/release-notes.md:47 in 44f07d9bf8
      41 | @@ -42,11 +42,16 @@ Notable changes
      42 |  - #35691 chainparams: delete my DNS seed
      43 |  - #35766 p2p: Assume v2transport for addresses from seeds
      44 |  
      45 | +### Build
      46 | +
      47 | +- #36218 build: avoid pipe2 on Darwin (for now) - #36218
    


    hebasto commented at 4:54 PM on September 10, 2026:

    Duplicated "#36218"?

  6. hebasto approved
  7. hebasto commented at 4:54 PM on September 10, 2026: member

    ACK 44f07d9bf830affd0bf91723982fb73eaeabf9ab.

  8. doc: update release notes for v29.x 3aa499c794
  9. fanquake force-pushed on Sep 10, 2026
  10. hebasto approved
  11. hebasto commented at 4:58 PM on September 10, 2026: member

    re-ACK 3aa499c794573d1d417ddd97efcf9bbda5427ab5.

  12. fanquake merged this on Sep 11, 2026
  13. fanquake closed this on Sep 11, 2026

  14. fanquake deleted the branch on Sep 11, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-15 17:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me