[32.x] Backports for rc2 #36267

pull fanquake wants to merge 12 commits into bitcoin:32.x from fanquake:32_0_rc2_backports changing 20 files +136 −87
  1. fanquake commented at 8:56 AM on September 16, 2026: member

    Backports:

  2. guix: Use osslsigncode 2.14
    Versions prior to osslsigncode 2.14 unconditionally perform a full verification
    of the binary after signatures are attached. This verification requires
    having a reasonably up to date root CA file, and since 2.6, CRLs are
    validated which requires network access.
    
    The current manifest is both missing the root CA file, and the guix
    container does not and should not have network access.
    
    Our current guix time-machine has 2.13, while bumping it would give us
    2.14, that seems to be problematic for other packages, see #36233
    and #35855. Instead this copies in the package for osslsigncode 2.14 from
    guix.
    
    Github-Pull: #36256
    Rebased-From: 66eeac216ad5b5b8d42a727aa730d7fc603f55fe
    93229d8cdf
  3. guix: Validate codesigned windows binaries
    `osslsigncode attach-signature` doesnot validate the signature at all,
    but we should be doing a signature check after applying to ensure that
    the signature itself is also valid.
    
    To avoid requiring the container to have network access, CRL checks are
    disabled.
    
    The package `nss-certs` is required so that a root CA file is available.
    
    Github-Pull: #36256
    Rebased-From: 59a465ce37829b2305319b378e8e85c9e653f29a
    e3380390c6
  4. fanquake added this to the milestone 32.0 on Sep 16, 2026
  5. DrahtBot added the label Backport on Sep 16, 2026
  6. DrahtBot commented at 8:56 AM on September 16, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36267.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK willcl-ark, sedited
    Stale ACK instagibbs

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  7. torcontrol: Apply reconnect backoff after dropped connections
    Github-Pull: #36260
    Rebased-From: 4556ef62675400a4702d73c0a3e1dd4c7061a077
    deac114123
  8. fanquake marked this as ready for review on Sep 16, 2026
  9. instagibbs commented at 2:03 PM on September 17, 2026: member

    tACK https://github.com/bitcoin/bitcoin/pull/36267/commits/deac114123c0dd71c64db4a8e18338e768ddf54b

    Had bot reapply changes, came out clean, and directly tested the behavior of each commit to varying degrees, all good

  10. sedited approved
  11. sedited commented at 2:09 PM on September 17, 2026: contributor

    ACK deac114123c0dd71c64db4a8e18338e768ddf54b

  12. rpc: Reuse AsmapVersion in exportasmap
    Github-Pull: #36249
    Rebased-From: fdfd196908e1fce930ed0554d8a75d4be3cf5cec
    d000de3834
  13. init: Log asmap version from NetGroupManager
    Github-Pull: #36249
    Rebased-From: 0bc87365cac1ef8586a28d69eca95d8080512454
    c6c6fa4374
  14. test: Check embedded asmap version log and addrman re-bucketing
    Github-Pull: #36249
    Rebased-From: dd5a8a63b2232279e2ea46e4360434d36f379774
    edf799b4a0
  15. rpc: Add asmap_version to getnetworkinfo
    Github-Pull: #36249
    Rebased-From: 87ce88c1b53c0a954a53b5a1856ef0d20850f3d5
    c1fb38c3e3
  16. doc: Describe how to verify the asmap in use
    Github-Pull: #36249
    Rebased-From: c1e9d15406fb7b46cff1cf385607a3e47fdd1bfb
    04eb5daa07
  17. netgroup: Cache asmap version
    Github-Pull: #36249
    Rebased-From: 0b353a9e872e81b900a543d7fedf668be3afec2c
    e4966be2db
  18. refactor: Use static const over inline const to work around ld64 bug
    This partially reverts fa74f58a262096f25d5a3a4ec4951f4ce2a31792 to avoid
    initialization dependencies, which the linker fails to handle properly.
    
    Github-Pull: #36285
    Rebased-From: fa8fefb29b6ce00c27638bc1c6f8ab5d58d48cb0
    0d4d0ce37b
  19. build: bump to v32.0rc2 e666f1d1cd
  20. doc: generate man pages fdd5414d0d
  21. fanquake commented at 9:47 AM on September 18, 2026: member

    Added some more backports, and added a bump to 32.0rc2.

  22. willcl-ark approved
  23. willcl-ark commented at 10:03 AM on September 18, 2026: member

    ACK fdd5414d0d307d024213f85c5fe5621091ea4ba0

    Backports all LGTM.

    I didn't think about it reviewing the original PR, but would we give the new RPC result field from #36249 a release note ordinarily?

  24. DrahtBot requested review from sedited on Sep 18, 2026
  25. DrahtBot requested review from instagibbs on Sep 18, 2026
  26. sedited commented at 10:39 AM on September 18, 2026: contributor

    I didn't think about it reviewing the original PR, but would we give the new RPC result field from #36249 a release note ordinarily?

    It's going into this release, so I didn't think creating a release note was necessary. It should instead be added to the wiki.

  27. sedited approved
  28. sedited commented at 10:41 AM on September 18, 2026: contributor

    ACK fdd5414d0d307d024213f85c5fe5621091ea4ba0

  29. sedited merged this on Sep 18, 2026
  30. sedited closed this on Sep 18, 2026

  31. fanquake deleted the branch on Sep 18, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-06 17:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me