A follow-up reverting #36057, now that we've branched off for 33.x.
Also documents mingw-w64 requirements (#32380).
Revert #36057 & document mingw-w64 requirement #36271
pull fanquake wants to merge 3 commits into bitcoin:master from fanquake:revert_36057 changing 6 files +5 −19-
fanquake commented at 12:36 PM on September 16, 2026: member
-
e394ba6dae
Revert "build: check for SetThreadDescription() at configure time"
This reverts commit bed46bd16c2b34eec62849b96cebbbdbcdd2c1ac.
-
DrahtBot commented at 12:36 PM on September 16, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36271.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process.
Type Reviewers ACK ViniciusCestarii Concept ACK hebasto If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
doc: document mingw-w64 requirement in Windows build docs 93ae95aeca
- fanquake force-pushed on Sep 16, 2026
-
nix: drop MSVCRT build ce76c082ce
-
in depends/README.md:170 in bc63b06914
166 | @@ -167,7 +167,6 @@ Some Ubuntu or Debian versions may not offer a working package. In this case, 167 | you may install `nix-bin` and use the Nix shell from the repository root: 168 | 169 | apt install nix-bin 170 | - NIX_BUILD_SHELL=bash HOST=x86_64-w64-mingw32 nix-shell contrib/devtools/shell-win64-cross.nix # MSVCRT 171 | NIX_BUILD_SHELL=bash HOST=x86_64-w64-mingw32ucrt nix-shell contrib/devtools/shell-win64-cross.nix # UCRT
maflcko commented at 2:01 PM on September 16, 2026:I think this one can be removed as well now:
diff --git a/contrib/devtools/shell-win64-cross.nix b/contrib/devtools/shell-win64-cross.nix index 4fd83b0..7e0da92 100644 --- a/contrib/devtools/shell-win64-cross.nix +++ b/contrib/devtools/shell-win64-cross.nix @@ -10,8 +10,3 @@ let - host = builtins.getEnv "HOST"; - crossPkgs = if host == "x86_64-w64-mingw32ucrt" - then pkgs.pkgsCross.ucrt64 - else if host == "x86_64-w64-mingw32" - then pkgs.pkgsCross.mingwW64 - else throw "Unsupported HOST: ${host}"; + crossPkgs = pkgs.pkgsCross.ucrt64; toolchain = crossPkgs.stdenv.cc.targetPrefix; diff --git a/depends/README.md b/depends/README.md index 3cee78a..f17bcab 100644 --- a/depends/README.md +++ b/depends/README.md @@ -169,4 +169,3 @@ you may install `nix-bin` and use the Nix shell from the repository root: apt install nix-bin - NIX_BUILD_SHELL=bash HOST=x86_64-w64-mingw32ucrt nix-shell contrib/devtools/shell-win64-cross.nix # UCRT + NIX_BUILD_SHELL=bash nix-shell contrib/devtools/shell-win64-cross.nix
fanquake commented at 2:07 PM on September 16, 2026:Sure, dropped.
fanquake force-pushed on Sep 16, 2026DrahtBot added the label CI failed on Sep 16, 2026DrahtBot removed the label CI failed on Sep 16, 2026ViniciusCestarii commented at 7:28 PM on September 16, 2026: contributorACK ce76c082cead6a107d1c95f584a0eff390b3539f
DrahtBot requested review from hebasto on Sep 16, 2026
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-20 21:51 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-20 21:51 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me