index: Delete old coinstats index directory on startup #36292

pull fjahr wants to merge 2 commits into bitcoin:master from fjahr:2026-09-coinstats-b-gone changing 3 files +16 −6
  1. fjahr commented at 7:57 PM on September 17, 2026: contributor

    coinstatsindex was updated in an incompatible way in v30 (see #30469) and moved to the indexes/coinstatsindex folder. The old indexes/coinstats directory was kept and a warning was logged so users could still downgrade to v29 without resyncing the index.

    There was a TODO in the code that scheduled the deletion for v31. Since v32 branch-off has happened, this would now ship in v33. By then 29.x should be EOL assuming we are not going to release a v29.5.

  2. DrahtBot added the label UTXO Db and Indexes on Sep 17, 2026
  3. DrahtBot commented at 7:57 PM on September 17, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    Concept ACK mzumsande
    Stale ACK sedited

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    No conflicts as of last run.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. mzumsande commented at 9:33 PM on September 17, 2026: contributor

    Concept ACK

  5. sedited approved
  6. sedited commented at 8:31 AM on September 18, 2026: contributor

    ACK 82e4cc6964a9a130d3a41454e046af964ea05508

  7. DrahtBot requested review from mzumsande on Sep 18, 2026
  8. fanquake added this to the milestone 33.0 on Sep 18, 2026
  9. bartoli commented at 6:52 PM on September 23, 2026: none

    Shouldn't deletion of the old one be done after the creation of the new one that potentially did not yet occur? The new one shouldn't need to have the old one to be created, but that 'feels' risky?

  10. fjahr commented at 9:15 PM on September 23, 2026: contributor

    Shouldn't deletion of the old one be done after the creation of the new one that potentially did not yet occur? The new one shouldn't need to have the old one to be created, but that 'feels' risky?

    This isn't a concern. The new index doesn't use the old version at all. It is incompatible and has been synced from scratch since v30, so the old data is never read from there and so the order doesn't matter.

  11. DrahtBot added the label Needs rebase on Nov 2, 2026
  12. index: Delete old coinstats index directory on startup bcd8fda1f6
  13. doc: Add release note for old coinstatsindex directory deletion 2b89e50fce
  14. fjahr force-pushed on Nov 3, 2026
  15. fjahr commented at 3:41 PM on November 3, 2026: contributor

    Rebased

  16. DrahtBot removed the label Needs rebase on Nov 3, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-06 23:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me