ci: simplify macOS codesign check #36302

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:cleanup_macos_codesign changing 2 files +3 −5

fanquake commented at 3:20 PM on September 20, 2026: member

Followup to #34914. See #34914 (review).

ci: simplify macOS codesign check

Co-authored-by: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>

716e8605e5

DrahtBot added the label Tests on Sep 20, 2026
DrahtBot commented at 3:20 PM on September 20, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36302.



Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers

ACK maflcko, Sjors, willcl-ark

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.

Type	Reviewers
ACK	maflcko, Sjors, willcl-ark

maflcko commented at 5:18 PM on September 20, 2026: member

lgtm ACK 716e8605e5c8a85400be15b3ce4a2eaef8045435

ci output looks garbled, but this is unrelated:

https://github.com/bitcoin/bitcoin/actions/runs/35519274609/job/106100423320#step:9:2450

+ codesign --verify --deep --strict '/Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ ₿🧪_/build-aarch64-apple-darwin24.6.0/deploy/Bitcoin-Qt.app'
finishing deferred symbolic links:
  /Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ �?��?��_/build-aarch64-apple-darwin24.6.0/deploy/Bitcoin-Qt.app/Contents/Frameworks/QtGui.framework/Resources -> Versions/Current/Resources
  /Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ �?��?��_/build-aarch64-apple-darwin24.6.0/deploy/Bitcoin-Qt.app/Contents/Frameworks/QtGui.framework/Versions/Current -> A
  /Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ �?��?��_/build-aarch64-apple-darwin24.6.0/deploy/Bitcoin-Qt.app/Contents/Frameworks/QtGui.framework/QtGui -> Versions/Current/QtGui
  /Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ �?��?��_/build-aarch64-apple-darwin24.6.0/deploy/Bitcoin-Qt.app/Contents/Frameworks/QtDBus.framework/Resources -> Versions/Current/Resources
  /Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ �?��?��_/build-aarch64-apple-darwin24.6.0/deploy/Bitcoin-Qt.app/Contents/Frameworks/QtDBus.framework/Versions/Current -> A
  /Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ �?��?��_/build-aarch64-apple-darwin24.6.0/deploy/Bitcoin-Qt.app/Contents/Frameworks/QtDBus.framework/QtDBus -> Versions/Current/QtDBus
  /Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ �?��?��_/build-aarch64-apple-darwin24.6.0/deploy/Bitcoin-Qt.app/Contents/Frameworks/QtCore.framework/Resources -> Versions/Current/Resources
  /Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ �?��?��_/build-aarch64-apple-darwin24.6.0/deploy/Bitcoin-Qt.app/Contents/Frameworks/QtCore.framework/Versions/Current -> A
  /Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ �?��?��_/build-aarch64-apple-darwin24.6.0/deploy/Bitcoin-Qt.app/Contents/Frameworks/QtCore.framework/QtCore -> Versions/Current/QtCore
  /Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ �?��?��_/build-aarch64-apple-darwin24.6.0/deploy/Bitcoin-Qt.app/Contents/Frameworks/QtWidgets.framework/Resources -> Versions/Current/Resources
  /Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ �?��?��_/build-aarch64-apple-darwin24.6.0/deploy/Bitcoin-Qt.app/Contents/Frameworks/QtWidgets.framework/Versions/Current -> A
  /Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ �?��?��_/build-aarch64-apple-darwin24.6.0/deploy/Bitcoin-Qt.app/Contents/Frameworks/QtWidgets.framework/QtWidgets -> Versions/Current/QtWidgets
  /Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ �?��?��_/build-aarch64-apple-darwin24.6.0/deploy/Bitcoin-Qt.app/Contents/Frameworks/QtNetwork.framework/QtNetwork -> Versions/Current/QtNetwork
  /Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ �?��?��_/build-aarch64-apple-darwin24.6.0/deploy/Bitcoin-Qt.app/Contents/Frameworks/QtNetwork.framework/Resources -> Versions/Current/Resources
  /Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ �?��?��_/build-aarch64-apple-darwin24.6.0/deploy/Bitcoin-Qt.app/Contents/Frameworks/QtNetwork.framework/Versions/Current -> A

Sjors commented at 11:43 AM on September 21, 2026: member

ACK 716e8605e5c8a85400be15b3ce4a2eaef8045435
willcl-ark approved
willcl-ark commented at 1:05 PM on September 22, 2026: member

code review ACK 716e8605e5c8a85400be15b3ce4a2eaef8045435
sedited merged this on Sep 22, 2026
sedited closed this on Sep 22, 2026
fanquake deleted the branch on Sep 23, 2026

Contributors

Labels

Linked (view graph)

#34914 contrib: replace deprecated --deep codesign flag, fix accidental --verify skip on ci

ci: simplify macOS codesign check #36302

Code Coverage & Benchmarks

Reviews