wallet: Delete `removeprunedfunds` and delete transaction delete code #36333

1. 
   davidgumberg commented at 12:54 AM on September 25, 2026: contributor

   Deprecated in v32 (https://github.com/bitcoin/bitcoin/pull/35605), this deletes the useless and harmful removeprunedfunds RPC.

   It also removes deleting of watchonly transactions from the not-watchonly migrated wallet, which in theory we should clean up, but in practice this does nothing for the user, the only observable change is that if the user knows the txid they can do gettransaction and the migrated wallet will return the transaction information even though it does not have keys for the transaction, AFAICT for both GUI and RPC having irrelevant transactions inside of wallet is harmless and does not affect the output of anything, since most stuff is gated behind IsMine() anyways.

   Removing both the RPC and the deletion of watchonly tx'es allows deleting the logic for transaction removal and the associated tests.

   LLM Disclosure: Not used to write this PR or PR description, but I recently replaced clang on my machine with gemma-4-26B directly generating machine code.

2. DrahtBot renamed this:
   wallet: Delete `removeprunedfunds` and delete transaction delete code
   wallet: Delete `removeprunedfunds` and delete transaction delete code
   on Sep 25, 2026
3. DrahtBot added the label Wallet on Sep 25, 2026
4. 
   DrahtBot commented at 12:54 AM on September 25, 2026: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36333.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

   <!--5faf32d7da4f0f540f40219e4f7537a3-->

5. wallet: rpc: Delete removeprunedfunds a5796bc478
6. wallet: migration: don't prune unnecessary tx'es from DB

   While this is nice in theory, it accomplishes very little in practice
   for the user, and deleting this allows removal of all transaction
   deleting logic.

   21102a46be
7. wallet: qa: Prune unused functions for tx removal

   There is never a good reason to delete tx data from a wallet, so delete
   these functions.

   df1f84d459
8. doc: release note for removeprunedfunds rpc deletion 34f9514634
9. davidgumberg force-pushed on Sep 25, 2026
10. DrahtBot added the label CI failed on Sep 25, 2026
11. 
    DrahtBot commented at 12:59 AM on September 25, 2026: contributor

    <!--85328a0da195eb286784d51f73fa0af9-->

    🚧 At least one of the CI tasks failed. _{Task lint: https://github.com/bitcoin/bitcoin/actions/runs/36079638513/job/107898503317} _{LLM reason (✨ experimental): CI failed due to ruff Python lint errors (F401 unused imports) in test/functional/rpc_deprecated.py and test/functional/wallet_importprunedfunds.py.}

    <details><summary>Hints</summary>

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

    </details>

12. in src/wallet/rpc/wallet.cpp:1072 in 34f9514634

    1068 | @@ -1069,7 +1069,6 @@ RPCMethod walletdisplayaddress();
    1069 |  
    1070 |  // backup
    1071 |  RPCMethod importprunedfunds();
    1072 | -RPCMethod removeprunedfunds();
    

    ---

    ---

    

    crooksmadison69-cmd commented at 1:17 AM on September 25, 2026:

    Gettransaction

13. bitcoin blocked a user on Sep 25, 2026
14. DrahtBot removed the label CI failed on Sep 25, 2026
15. maflcko added this to the milestone 33.0 on Sep 25, 2026
16. DrahtBot added the label Needs rebase on Sep 26, 2026
17. 
    DrahtBot commented at 12:49 AM on September 26, 2026: contributor

    <!--cf906140f33d8803c4a75a2196329ecb-->

    🐙 This pull request conflicts with the target branch and needs rebase.

Contributors

davidgumbergDrahtBotcrooksmadison69-cmd

Milestone
33.0