util: remove unused exception parameter in `Popen::execute_process` #36383

1. 
   fanquake commented at 5:08 PM on September 29, 2026: member

   [451/1129] Building CXX object src/CMakeFiles/bitcoin_common.dir/common/run_command.cpp.o
   In file included from ../src/common/run_command.cpp:10:
   ../src/util/subprocess.h:1219:30: warning: unused exception parameter 'exp' [-Wunused-exception-parameter]
    1219 |     } catch (std::exception& exp) {
         |                              ^~~
   1 warning generated.
   

   Related to #36167.

2. DrahtBot added the label Utils/log/libs on Sep 29, 2026
3. 
   DrahtBot commented at 5:08 PM on September 29, 2026: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36383.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline and AI policy for information on the review process.

   Type	Reviewers
   ACK	musaHaruna, maflcko

   If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #36167 ([RFC] Enable -Wunused by fanquake)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

   <!--5faf32d7da4f0f540f40219e4f7537a3-->

4. DrahtBot added the label CI failed on Sep 29, 2026
5. util: remove unused exception parameter in Popen::execute_process 1b00dff743
6. build: enable -Wunused-exception-parameter cde2f2ec64
7. 
   fanquake commented at 9:19 AM on September 30, 2026: member

   Upstreamed in https://github.com/arun11299/cpp-subprocess/pull/133.

8. fanquake force-pushed on Sep 30, 2026
9. DrahtBot removed the label CI failed on Sep 30, 2026
10. fanquake requested review from hebasto on Oct 1, 2026
11. 
    musaHaruna commented at 10:32 AM on October 1, 2026: contributor

    ACK cde2f2e

    Checked that removing exp leaves the catch type, cleanup call, and throw; unchanged.

    Built on macOS arm64 with Apple Clang 17, with -Wunused-exception-parameter and -Werror enabled. Confirmed the original header triggers the warning and the updated header compiles successfully.

12. 
    maflcko commented at 11:37 AM on October 1, 2026: member

    Built on macOS arm64 with Apple Clang 17

    Unrelated, but I see you are compiling with Apple Clang 17. I wonder which exact version, because in #36287 I bump to the latest Apple Clang 17 version. So I wonder if this works for you, or if you'd have to upgrade your macOS and/or XCode.

13. 
    maflcko commented at 11:38 AM on October 1, 2026: member

    lgtm ACK cde2f2ec641acfb7ab11e5d37182b5fcafb65a94

    Seems fine to enforce this as a small, mostly-style preference.

14. 
    musaHaruna commented at 12:01 PM on October 1, 2026: contributor

    Unrelated, but I see you are compiling with Apple Clang 17. I wonder which exact version, because in #36287 I bump to the latest Apple Clang 17 version. So I wonder if this works for you, or if you'd have to upgrade your macOS and/or XCode.

    I’m using Apple Clang 17.0.0 (clang-1700.6.3.2) from Command Line Tools 26.2, on macOS 26.0 (arm64). I haven't looked at #36287 yet, but I will take a look.

Review Requested
hebasto