Fixes #36388 (llvm-symbolizer broken pipe complaints) by replacing the unclean Bitcoin Core shutdown with a clean one in init_fd_overflow_test.
test: Extract and use sigterm_node in init_fd_overflow_test #36392
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2609-test-term-kill-llvm-symbolizer-pipe-error changing 1 files +23 −25-
maflcko commented at 2:04 PM on September 30, 2026: member
- DrahtBot added the label Tests on Sep 30, 2026
-
DrahtBot commented at 2:04 PM on September 30, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36392.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- DrahtBot added the label CI failed on Sep 30, 2026
- maflcko force-pushed on Sep 30, 2026
- DrahtBot removed the label CI failed on Sep 30, 2026
-
fad49a733d
test: Extract and use sigterm_node in init_fd_overflow_test
Changes: * Extract a shared get_process_group_kwargs() to avoid repeating it * In sigterm_node, use node.wait_until_stopped() instead of the manual assert_equal(0, node.process.wait()) * Extract sigterm_node; can be reviewed via the git options --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space * Use self.sigterm_node(node)+get_process_group_kwargs() over node.kill_process() for a graceful shutdown to avoid complaints from the llvm-symbolizer about a broken pipe when it resolves UBSAN suppressions during a process kill
- maflcko force-pushed on Sep 30, 2026
