I cannot see any maybe-uninitialized warnings in CI logs, and this passes locally on aarch64.
ci: drop `-Wno-error=maybe-uninitialized` from win64 cxx flags #36411
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:win_drop_maybe_uninitialized changing 1 files +1 −2-
fanquake commented at 9:42 AM on October 2, 2026: member
-
ci: drop -Wno-error=maybe-uninitialized from win64 flags 963f557a72
- DrahtBot added the label Tests on Oct 2, 2026
-
DrahtBot commented at 9:42 AM on October 2, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36411
- Ralph review: https://git.fish.foo/bitcoin/bitcoin/pulls/36411#author-ralph
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process.
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- hebasto approved
-
hebasto commented at 10:40 AM on October 2, 2026: member
I cannot see any
maybe-uninitializedwarnings in CI logs, and this passes locally on aarch64.This is interesting.
The CI job uses GCC 14.3:
C++ compiler .......................... GNU 14.3.0, /nix/store/wj1z9dwd3w62nfhvvla4bk1f3fq6mxi0-x86_64-w64-mingw32-gcc-wrapper-14.3.0/bin/x86_64-w64-mingw32-g++However, newer compilers still produce the
maybe-uninitializedwarning, as noted in #35606 (comment). For example:- on Fedora:
C++ compiler .......................... GNU 16.2.1, /bin/x86_64-w64-mingw32ucrt-g++- on macOS + Homebrew:
C++ compiler .......................... GNU 16.2.0, /opt/homebrew/bin/x86_64-w64-mingw32-g++ACK 963f557a721b279a643db2982893c8aa667416c6 for our current CI job.
-
maflcko commented at 2:43 PM on October 2, 2026: member
lgtm ACK 963f557a721b279a643db2982893c8aa667416c6
thx
- fanquake merged this on Oct 2, 2026
- fanquake closed this on Oct 2, 2026