ci: drop `-Wno-error=maybe-uninitialized` from win64 cxx flags #36411

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:win_drop_maybe_uninitialized changing 1 files +1 −2
  1. fanquake commented at 9:42 AM on October 2, 2026: member

    I cannot see any maybe-uninitialized warnings in CI logs, and this passes locally on aarch64.

  2. ci: drop -Wno-error=maybe-uninitialized from win64 flags 963f557a72
  3. DrahtBot added the label Tests on Oct 2, 2026
  4. DrahtBot commented at 9:42 AM on October 2, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK hebasto, maflcko

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. hebasto approved
  6. hebasto commented at 10:40 AM on October 2, 2026: member

    I cannot see any maybe-uninitialized warnings in CI logs, and this passes locally on aarch64.

    This is interesting.

    The CI job uses GCC 14.3:

    C++ compiler .......................... GNU 14.3.0, /nix/store/wj1z9dwd3w62nfhvvla4bk1f3fq6mxi0-x86_64-w64-mingw32-gcc-wrapper-14.3.0/bin/x86_64-w64-mingw32-g++
    

    However, newer compilers still produce the maybe-uninitialized warning, as noted in #35606 (comment). For example:

    • on Fedora:
    C++ compiler .......................... GNU 16.2.1, /bin/x86_64-w64-mingw32ucrt-g++
    
    • on macOS + Homebrew:
    C++ compiler .......................... GNU 16.2.0, /opt/homebrew/bin/x86_64-w64-mingw32-g++
    

    ACK 963f557a721b279a643db2982893c8aa667416c6 for our current CI job.

  7. maflcko commented at 2:43 PM on October 2, 2026: member

    lgtm ACK 963f557a721b279a643db2982893c8aa667416c6

    thx

  8. fanquake merged this on Oct 2, 2026
  9. fanquake closed this on Oct 2, 2026

  10. Kino1994 referenced this in commit f3f04bf003 on Oct 5, 2026
  11. fanquake deleted the branch on Oct 6, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-24 00:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me