Replace our hand-rolled IPv4/IPv6 parser, with ipaddress.ip_address(addr).packed.hex().
test: use ipaddress in addr_to_hex #36416
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:switch_to_ipaddress changing 1 files +2 −23-
fanquake commented at 1:51 PM on October 2, 2026: member
-
97298c0c4f
test: use ipaddress in addr_to_hex
Replace our hand-rolled IPv4/IPv6 parser, with `ipaddress.ip_address(addr).packed.hex()`.
- DrahtBot added the label Tests on Oct 2, 2026
-
DrahtBot commented at 1:51 PM on October 2, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36416
- Ralph review: https://git.fish.foo/bitcoin/bitcoin/pulls/36416#author-ralph
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process.
Type Reviewers Concept ACK sipa If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
sipa commented at 2:18 PM on October 2, 2026: member
Concept ACK
