Test: Add legacy script edge cases to taproot test #36455

pull benthecarman wants to merge 1 commits into bitcoin:master from benthecarman:taproot-legacy-edge-spenders changing 1 files +30 −0
  1. benthecarman commented at 7:18 PM on October 7, 2026: contributor

    Add feature_taproot spenders for script edge cases that other implementations have gotten wrong: CSV with -2, a 5-byte operand whose value fits in 1 byte, IFDUP on negative or non-minimal zero, ROLL with duplicate values, and OP_16 in a P2SH scriptSig.

    Each case hits an already-covered branch, so the minimizer drops it, and none are caught by the current vectors. Naming them lets their dumps be added to the script assets.

    These were discovered by finding gaps in an alternate implementation (bitcoin-s)

    Script assets: bitcoin-core/qa-assets#297

  2. Test: Add legacy script edge cases to taproot test
    Add feature_taproot spenders for script edge cases that other
    implementations have gotten wrong: CSV with -2, a 5-byte operand whose
    value fits in 1 byte, IFDUP on negative or non-minimal zero, ROLL with
    duplicate values, and OP_16 in a P2SH scriptSig.
    
    Each case hits an already-covered branch, so the minimizer drops it,
    and none are caught by the current vectors. Naming them lets their
    dumps be added to the script assets.
    fcfd8aa09b
  3. DrahtBot added the label Tests on Oct 7, 2026
  4. DrahtBot commented at 7:19 PM on October 7, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-08 23:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me