Test: Cover malformed and truncated tx encodings #36456

pull benthecarman wants to merge 1 commits into bitcoin:master from benthecarman:test-tx-deser-truncation changing 2 files +42 −0

benthecarman commented at 7:21 PM on October 7, 2026: contributor

Add tests for a witness flag of 0x02, a witness element longer than the remaining data, truncated fields, and truncated CompactSize prefixes. Also check that DecodeHexTx does not fall back to reading these as a different non-witness transaction.

These were discovered by finding gaps in an alternate implementation (bitcoin-s)

Test: Cover malformed and truncated tx encodings

Add tests for a witness flag of 0x02, a witness element longer than
the remaining data, truncated fields, and truncated CompactSize
prefixes. Also check that DecodeHexTx does not fall back to reading
these as a different non-witness transaction.

3ddf182d04

DrahtBot added the label Tests on Oct 7, 2026
DrahtBot commented at 7:21 PM on October 7, 2026: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36456
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36456.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36456#author-ralph


Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers

Concept ACK darosior

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.
darosior commented at 7:31 PM on October 7, 2026: member

Concept ACK

Type	Reviewers
Concept ACK	darosior

Contributors

Labels

Test: Cover malformed and truncated tx encodings #36456

External sites

Reviews