bench: add BIP-352 pubkey extraction benchmarks (standard + P2PKH worst-case) #36475

pull theStack wants to merge 2 commits into bitcoin:master from theStack:bip352-bench-pubkey_extraction changing 2 files +98 −0

theStack commented at 2:30 PM on October 8, 2026: contributor

As there are ongoing changes to the Silent Payments public key extraction function GetPubKeyFromInput (see recently merged #36338, upcoming #36417), it seems reasonable to add benchmarks for it. The first commit covers the standard shape of each eligible input type (P2PKH, P2SH-P2WPKH, P2WPKH and P2TR key-path spend; see BIP-352). The second adds a worst-case P2PKH input with a maximally malleated scriptSig, where every push has to be hashed during the scan.

Results on my arm64 machine (as per $ ./build/bin/bench_bitcoin -filter='BIP352_.*'):

ns/input	input/s	err%	total	benchmark
3,034.12	329,584.35	0.2%	0.01	`BIP352_GetPubKey_P2PKH`
69,868.20	14,312.66	0.1%	0.01	`BIP352_GetPubKey_P2PKH_WorstCase`
2,841.35	351,945.44	0.1%	0.01	`BIP352_GetPubKey_P2SH_P2WPKH`
2,768.00	361,272.01	0.1%	0.01	`BIP352_GetPubKey_P2TR`
2,757.57	362,637.66	0.0%	0.01	`BIP352_GetPubKey_P2WPKH`

bench: add benchmarks for BIP-352 pubkey extraction (standard inputs)

Benchmark the public key extraction (`GetPubKeyFromInput`) for the
standard shape of each Silent Payments eligible input type, i.e.
P2PKH, P2SH-P2WPKH, P2WPKH and P2TR (key-path spend).

e39c1b1549

DrahtBot added the label Tests on Oct 8, 2026
DrahtBot commented at 2:30 PM on October 8, 2026: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36475
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36475.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36475#author-ralph


Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers

Concept ACK w0xlt

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.

Type	Reviewers
Concept ACK	w0xlt

bench: add worst-case P2PKH benchmark for BIP-352 pubkey extraction

Add a P2PKH input with a malleated scriptSig that prepends as many
33-byte pushes as the consensus scriptSig size limit (MAX_SCRIPT_SIZE)
allows, each of which has to be hashed during the scan, followed by the
actual signature and public key. The input respects all other consensus
limits (data pushes don't count towards MAX_OPS_PER_SCRIPT, the stack
stays below MAX_STACK_SIZE), but is non-standard as it exceeds
MAX_STANDARD_SCRIPTSIG_SIZE.

Results on my arm64 machine:
```
$ ./build/bin/bench_bitcoin -filter='BIP352_.*'
[...]

|            ns/input |             input/s |    err% |     total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
|            3,034.12 |          329,584.35 |    0.2% |      0.01 | `BIP352_GetPubKey_P2PKH`
|           69,868.20 |           14,312.66 |    0.1% |      0.01 | `BIP352_GetPubKey_P2PKH_WorstCase`
|            2,841.35 |          351,945.44 |    0.1% |      0.01 | `BIP352_GetPubKey_P2SH_P2WPKH`
|            2,768.00 |          361,272.01 |    0.1% |      0.01 | `BIP352_GetPubKey_P2TR`
|            2,757.57 |          362,637.66 |    0.0% |      0.01 | `BIP352_GetPubKey_P2WPKH`

```

747514aeb4

theStack force-pushed on Oct 8, 2026
DrahtBot added the label CI failed on Oct 8, 2026
w0xlt commented at 5:52 PM on October 8, 2026: contributor

Concept ACK

Contributors

Labels

Linked (view graph)

#36338 BIP-352: fix P2PKH pubkey extraction from malleated scriptSig #36417 bip352: verify redeem script and pubkey hash in GetPubKeyFromInput

bench: add BIP-352 pubkey extraction benchmarks (standard + P2PKH worst-case) #36475

External sites

Reviews