"all" is added to the build targets unless GOAL is "all" or contains "codegen". This implicit translation can be confusing, so explicitly spell out the targets as "all", "all deploy", etc., where needed.
Also, use the eval-based string-to-argv conversion for BUILD_TARGETS to avoid disabling shellcheck SC2086.
ci: refactor BUILD_TARGETS use #36485
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2610-ci-config-cleanup changing 12 files +15 −20-
maflcko commented at 8:03 AM on October 9, 2026: member
-
fa5643ff99
ci: refactor BUILD_TARGETS use
"all" is added to the build targets unless GOAL is "all" or contains "codegen". This implicit translation can be confusing, so explicitly spell out the targets as "all", "all deploy", etc., where needed. Also, use the eval-based string-to-argv conversion for BUILD_TARGETS to avoid disabling shellcheck SC2086.
- DrahtBot added the label Tests on Oct 9, 2026
-
DrahtBot commented at 8:03 AM on October 9, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36485
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36485.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36485#author-ralph
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process.
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
hebasto commented at 12:26 PM on October 9, 2026: member
Concept ACK.
-
fanquake commented at 7:47 AM on October 13, 2026: member
ACK fa5643ff99af95227abb7a0b031e1dfbe4019dd7
- DrahtBot requested review from hebasto on Oct 13, 2026
- hebasto approved
-
hebasto commented at 1:27 PM on October 13, 2026: member
ACK fa5643ff99af95227abb7a0b031e1dfbe4019dd7.
- hebasto merged this on Oct 13, 2026
- hebasto closed this on Oct 13, 2026
- maflcko deleted the branch on Oct 13, 2026
