test: Add missing sync_mempools in wallet_conflicts.py #36553

pull maflcko wants to merge 2 commits into bitcoin:master from maflcko:2610-test-fix-wallet-conflict-race changing 1 files +5 −4
  1. maflcko commented at 1:13 PM on October 16, 2026: member

    Fix https://github.com/bitcoin/bitcoin/actions/runs/38882212577/job/116911393791?pr=36545#step:11:3700:

    2026-10-16T09:48:01.724540Z TestFramework (INFO): Test a scenario where a transaction has a mempool conflict
    2026-10-16T09:48:02.100649Z TestFramework (INFO): Test scenario where a mempool conflict is removed
    2026-10-16T10:28:02.397150Z TestFramework (ERROR): Unexpected exception:
    Traceback (most recent call last):
      File "/home/runner/work/_temp/test/functional/test_framework/test_framework.py", line 146, in main
        self.run_test()
        ~~~~~~~~~~~~~^^
      File "/home/runner/work/_temp/build_ ₿🧪_/test/functional/wallet_conflicts.py", line 38, in run_test
        self.test_mempool_conflict()
        ~~~~~~~~~~~~~~~~~~~~~~~~~~^^
      File "/home/runner/work/_temp/build_ ₿🧪_/test/functional/wallet_conflicts.py", line 202, in test_mempool_conflict
        self.generate(self.nodes[2], 1)
        ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
      File "/home/runner/work/_temp/test/functional/test_framework/test_framework.py", line 668, in generate
        sync_fun() if sync_fun else self.sync_all()
                                    ~~~~~~~~~~~~~^^
      File "/home/runner/work/_temp/test/functional/test_framework/test_framework.py", line 750, in sync_all
        self.sync_mempools(nodes)
        ~~~~~~~~~~~~~~~~~~^^^^^^^
      File "/home/runner/work/_temp/test/functional/test_framework/test_framework.py", line 743, in sync_mempools
        raise AssertionError("Mempool sync timed out after {}s:{}".format(
        ...<2 lines>...
        ))
    AssertionError: Mempool sync timed out after 2400s:
      {'ed4cecf5b16f82ce48b2c56b6a20feac3f83e6043b262a74f356e07a451dda34'}
      {'47de6fdef43b22320dc0114c2104e3dee58de9591799ff5e48ff29efaa5cf88f', 'ed4cecf5b16f82ce48b2c56b6a20feac3f83e6043b262a74f356e07a451dda34'}
      {'ed4cecf5b16f82ce48b2c56b6a20feac3f83e6043b262a74f356e07a451dda34'}
    

    by adding the missing sync_mempools.

  2. DrahtBot renamed this:
    test: Add missing sync_mempools in wallet_conflicts.py
    test: Add missing sync_mempools in wallet_conflicts.py
    on Oct 16, 2026
  3. DrahtBot added the label Tests on Oct 16, 2026
  4. DrahtBot commented at 1:13 PM on October 16, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK fanquake

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. test: Remove redundant sync call after self.generate called sync_all fa3986f5c1
  6. test: Add missing sync_mempools in wallet_conflicts.py
    tx1 and tx3 do not conflict. While alice (node 0) ends with tx3, other
    nodes may end up with tx1 and tx3, if they request tx2 after alice has
    replaced it, thus not receiving it.
    
    Fix it by calling self.sync_mempools() after each send.
    
    Also, replace one nodes[0] with the alice alias.
    
    Also, generate the final cleanup block on bob, to avoid another
    sync_mempools.
    fa1061481b
  7. maflcko force-pushed on Oct 19, 2026
  8. fanquake commented at 3:02 AM on October 20, 2026: member

    ACK fa1061481bb1cb6bb7d5ca7ea6674f349f2baed8

  9. fanquake merged this on Oct 20, 2026
  10. fanquake closed this on Oct 20, 2026

  11. maflcko deleted the branch on Oct 20, 2026
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-21 18:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me