During rbitcoin's development, we created some additional script test vectors, some of which seem like they would be valuable additions to bitcoin core's script tests.
These cover mostly script limits on various versions, but also the non-FindAndDelete behavior of witness v0.
Add script tests for witness v0 size limits and the lack of those same
limits in tapscript.
Add script tests that verify OP_SUCCESS handling before script limits
are applied.
Add script tests validating the lack of FindAndDelete behavior when
executing witness v0 scripts.
Add script tests for tapscript signature weight, including for
non-empty, non-32-byte keys, and empty and non-empty signatures.
Add script tests that validate unknown tapleaves are not subject to
tapleaf 0xc2 witness limits.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline and AI policy for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | Yudis-bit |
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
cc @instagibbs / @darosior
@reardencode are you looking to throw this over the fence or will you update it on review, or are you still going to add stuff later?
Just want to know what to do with this
Happy to update based on review. Not specifically planning to add stuff in the near future, but if we find other interesting cases and this kind of thing is useful to y'all, we'll make additional PRs later.
Tested ACK 60bb41f494 on Windows.