test: Fix intermittent timeout waiting for ibd_wtxid getdata #36599

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2610-test-race-fix-ibd_wtxid changing 1 files +14 −11
  1. maflcko commented at 7:06 AM on October 22, 2026: member

    Fix #36595

    diff to repro:

    diff --git a/src/validationinterface.cpp b/src/validationinterface.cpp
    index 128f14a6d5..92e1fad22e 100644
    --- a/src/validationinterface.cpp
    +++ b/src/validationinterface.cpp
    @@ -168,2 +168,3 @@ void ValidationSignals::SyncWithValidationInterfaceQueue()
                 LOG_EVENT("%s", local_log_msg);                                                                      \
    +            UninterruptibleSleep(99ms);\
                 local_event();                                                                                       \
    
  2. test: Fix intermittent timeout waiting for ibd_wtxid getdata 7777598f87
  3. DrahtBot added the label Tests on Oct 22, 2026
  4. DrahtBot commented at 7:07 AM on October 22, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK Naomi-Gift, mercie-ux

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. fanquake requested review from mzumsande on Oct 22, 2026
  6. Naomi-Gift commented at 8:19 AM on October 22, 2026: none

    tACK 7777598f87ea524721cf7dcc61517ca988df61aa I applied the 99ms sleep from the description, the old test times out at wait_for_getdata([ibd_wtxid]), the new one passes Without the sleep, the test passes normally

  7. mercie-ux commented at 9:17 AM on October 22, 2026: contributor

    ACK 7777598f87ea524721cf7dcc61517ca988df61aa

  8. fanquake merged this on Oct 22, 2026
  9. fanquake closed this on Oct 22, 2026

  10. fanquake referenced this in commit d37be8ad96 on Oct 22, 2026
  11. fanquake commented at 10:56 AM on October 22, 2026: member

    Backported to 32.x in #36596.

  12. fanquake commented at 11:00 AM on October 22, 2026: member

    Backported to 31.x in #36319.

  13. fanquake referenced this in commit 313ce99054 on Oct 22, 2026
  14. maflcko deleted the branch on Oct 22, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-26 03:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me