guix: add --no-same-owner to codesign.sh TAR_OPTIONS #36615

1. 
   marcofleon commented at 8:11 PM on October 22, 2026: contributor

   Just ran guix-codesign for v32.0 as root, in fanquake's container image (option 3 in INSTALL.md) and got this error while unpacking the codesigning tarball:

   tar: ./detached-sig-create.sh: Cannot change ownership to uid 0, gid 0: Invalid argument
   tar: ./unsigned/bitcoin-32.0: Cannot change ownership to uid 0, gid 0: Invalid argument
   tar: ./unsigned/bitcoin-32.0-win64-setup-unsigned.exe: Cannot change ownership to uid 0, gid 0: Invalid argument
   ...
   tar: Exiting with failure status due to previous errors
   

   Same happens for the macOS files.

   When updating guix in #34550, --no-same-owner was added in build.sh (now in setup.sh) in 0f323e10759aba4429677d0e1e202bf575b6d664, but not in codesign.sh. This PR adds it to TAR_OPTIONS in codesign.sh. This fixed the issue for me and my hashes match the other attestations for v32.0.

2. guix: add --no-same-owner to codesign.sh TAR_OPTIONS d2e5108ea2
3. DrahtBot added the label Build system on Oct 22, 2026
4. 
   DrahtBot commented at 8:11 PM on October 22, 2026: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   External sites

   • Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36615
   • Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36615.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36615#author-ralph

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline and AI policy for information on the review process.

   Type	Reviewers
   ACK	fanquake, willcl-ark

   If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

   <!--5faf32d7da4f0f540f40219e4f7537a3-->

5. 
   marcofleon commented at 8:13 PM on October 22, 2026: contributor

   Bit out of my depth here, so if there's a reason to not add this option for codesigning or I just shouldn't be doing this as root or something, let me know.

6. 
   fanquake commented at 11:41 AM on October 23, 2026: member

   Concept ACK

7. 
   willcl-ark commented at 9:08 PM on October 26, 2026: member

   Could that var be extracted into libexec/prelude.sh to avoid repeats?

8. fanquake added this to the milestone 32.2 on Oct 26, 2026
9. 
   fanquake commented at 2:58 PM on October 30, 2026: member

   Could that var be extracted

   Yes I think so.

10. 
    marcofleon commented at 2:07 PM on November 3, 2026: contributor

    extracted into libexec/prelude.sh

    I'm assuming you mean prelude.bash? Doesn't that only run outside of the guix container, so would tar options set in preclude.bash work?

    Regardless, I believe @fanquake has another PR in mind that would include this fix, so closing for now.

11. marcofleon closed this on Nov 3, 2026

    ---

12. 
    fanquake commented at 4:21 PM on November 3, 2026: member

    You're right. We'll need to pass the values in if we want to deduplicate. In any case, I'll open a PR with the other change.

13. fanquake removed this from the milestone 32.2 on Nov 4, 2026
14. fanquake reopened this on Nov 4, 2026

    ---

15. fanquake added this to the milestone 32.2 on Nov 4, 2026
16. 
    fanquake commented at 11:27 AM on November 4, 2026: member

    I think we should actually just move ahead with the change here. Left as-is so it's trivial to backport.

17. 
    fanquake commented at 11:38 AM on November 4, 2026: member

    ACK d2e5108ea2ddce1952d4db8b42d39a40e3d9f521

18. willcl-ark approved
19. 
    willcl-ark commented at 12:05 PM on November 4, 2026: member

    utACK d2e5108ea2ddce1952d4db8b42d39a40e3d9f521

    I've not bumped into this myself ever but the fix seems correct to me, and I'm fine with it being left simpler/non-deduplicated/easier to backport.

    Not running a guix build.

20. fanquake merged this on Nov 4, 2026
21. fanquake closed this on Nov 4, 2026

    ---

22. fanquake referenced this in commit d9035657b6 on Nov 4, 2026
23. 
    fanquake commented at 12:14 PM on November 4, 2026: member

    Backported to 32.x in #36727.

Milestone
32.2