For #19732 (see commit msgs for details)
test: Enable noban_tx_relay in a few more tests #36624
pull maflcko wants to merge 3 commits into bitcoin:master from maflcko:2610-test-noban-relay changing 43 files +43 −79-
maflcko commented at 2:50 PM on October 23, 2026: member
-
faf2e3aba5
test: Use proper noban permission for faster tx relay
A plain -whitelist=noban@127.0.0.1 misses the out connections.
-
fa6f7e36a8
test: [doc] Clarify noban_tx_relay comment
The comment is verbose and there are many whitelist permissions like `relay` or `mempool`, but this applies `noban` to in- and out- connections. A brief `self.noban_tx_relay = True # faster tx relay` covers the same meaning with less confusion.
-
fa704c5d3c
test: Use faster noban_tx_relay in mempool tests
Those tests do not check trickle relay delays or peer misbehavior
- DrahtBot added the label Tests on Oct 23, 2026
-
DrahtBot commented at 2:50 PM on October 23, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36624
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36624.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36624#author-ralph
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process.
Type Reviewers ACK ViniciusCestarii, brunoerg If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
fanquake commented at 3:27 PM on October 23, 2026: member
-
ViniciusCestarii commented at 6:20 PM on October 23, 2026: contributor
ACK fa704c5d3cafcd768982a02c48c7c7d96d667fa1
Setting noban_tx_relay to these tests is correct and I also like the new more direct comment for noban_tx_relay.
I compared execution time running locally
build/test/functional/test_runner.py -j=18 --randomseed=1(median of 3):rpc_psbt.py 18s -> 4s mempool_accept_wtxid.py 4s -> 0s mempool_limit.py 8s -> 4s mempool_package_rbf.py 13s -> 4s mempool_persist.py 12s -> 3s
Acummulated 1066s -> 1011s Wall 76s -> 73s
This is a nice speed up :)
- brunoerg approved
-
brunoerg commented at 7:30 PM on October 23, 2026: contributor
ACK fa704c5d3cafcd768982a02c48c7c7d96d667fa1
- fanquake merged this on Oct 23, 2026
- fanquake closed this on Oct 23, 2026
- maflcko deleted the branch on Oct 26, 2026
