fuzz: check GetStale() returns exactly the stale private broadcast txs #36670

pull frankomosh wants to merge 1 commits into bitcoin:master from frankomosh:2026-10-fuzz-private-broadcast-stale-check changing 1 files +26 −0
  1. frankomosh commented at 6:38 PM on October 26, 2026: contributor

    The private_broadcast fuzz test checks each tx that GetStale() returns. This adds to it by checking that all stale txs are returned. ReattemptPrivateBroadcast() only retries what GetStale() returns, and a stale tx left out is never retried.

    This partly came up during review in #35129#pullrequestreview-4427536924, and recently also surfaced in https://mutanthub.space/mutants/3752 , where changing continue to break in GetStale() passes all current tests.

    This PR records when each tx is added and when each node confirms it. Then it checks that GetStale() returns exactly the expected txs.

  2. fuzz: check GetStale() returns exactly the stale private broadcast txs
    Currently, the private_broadcast harness checks that each transaction
returned by GetStale() is known, unresolved and below the attempt cap.
This adds onto that by checking the timing rule, and that every stale
transaction is returned.

Track when each transaction is added and when each node confirms
reception, and check that GetStale() returns exactly the expected set.
    986cdf27b4
  3. DrahtBot added the label Fuzzing on Oct 26, 2026
  4. DrahtBot commented at 6:38 PM on October 26, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. fanquake added the label Private Broadcast on Oct 26, 2026
  6. fanquake commented at 7:29 PM on October 26, 2026: member

    cc @vasild @andrewtoth

Contributors
frankomoshDrahtBotfanquake
Labels
FuzzingPrivate Broadcast
Linked (view graph)
#35129 test: add fuzz test for private broadcast
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-26 22:51 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me