test: Replace stale TODO with mempoolminfee test in wallet_send.py #36705

pull Conradgabe wants to merge 1 commits into bitcoin:master from Conradgabe:test-send-fee-below-mempoolminfee changing 1 files +36 −10
  1. Conradgabe commented at 1:04 PM on October 30, 2026: none

    wallet_send.py had a commented-out TODO from the original send PR (#16378) about returning the hex when the fee rate is below the mempool minimum. The commented code was stale; estimate_mode="sat/b" no longer exists.

    Also, an explicit fee_rate is only checked against max(-mintxfee, -minrelaytxfee), not against mempoolminfee (see src/wallet/fees.cpp), so when the mempool is full, send can build a tx the node won't accept.

    This PR adds a subtest covering this cases and removes the stale TODO.

    With add_to_wallet=false, the returned hex is rejected by testmempoolaccept, and with add_to_wallet=true, send reports success, but the tx stays only in the wallet, not the mempool.

  2. test: cover send fee_rate below mempoolminfee 87d1b55950
  3. DrahtBot added the label Tests on Oct 30, 2026
  4. DrahtBot commented at 1:04 PM on October 30, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

    LLM Linter (✨ experimental)

    Possible typos and grammar issues:

    • test/functional/wallet_send.py: Cwallet::CommitTransaction → CWallet::CommitTransaction [class name capitalization typo]

    <sup>2026-10-30 13:04:50</sup>


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-30 15:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me