policy: remove unused GetVirtualTransactionInputSize #36706

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_getvirtualtransactioninputsize changing 4 files +1 −14

fanquake commented at 2:01 PM on October 30, 2026: member

The last non-test caller was removed in 9b7ec393b8 (#26567). Since then it has only been used by the tx_in fuzz target and a helper in wallet_tests.

policy: remove unused GetVirtualTransactionInputSize

The last non-test caller was removed in 9b7ec393b8 (#26567), when the
wallet switched to estimating input sizes using descriptors. Since then
it has only been used by the tx_in fuzz target and a helper in
wallet_tests.

3e2cf63da5

DrahtBot added the label TX fees and policy on Oct 30, 2026
DrahtBot commented at 2:02 PM on October 30, 2026: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36706
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36706.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36706#author-ralph


Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers

ACK l0rinc, jpk68

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.



LLM Linter (✨ experimental)

Possible places where named args for integral literals may be used (e.g. func(x, /*named_arg=*/0) in C++, and func(x, named_arg=0) in Python):
- src/wallet/test/wallet_tests.cpp: GetVirtualTransactionSize(GetTransactionInputWeight(tx_in), 0, 0)
<sup>2026-10-30 14:02:11</sup>

Type	Reviewers
ACK	l0rinc, jpk68

in src/wallet/test/wallet_tests.cpp:642 in 3e2cf63da5

 638 | @@ -639,7 +639,7 @@ static size_t CalculateNestedKeyhashInputSize(bool use_max_sig)
 639 |  
 640 |      CTxIn tx_in;
 641 |      UpdateInput(tx_in, sig_data);
 642 | -    return (size_t)GetVirtualTransactionInputSize(tx_in);
 643 | +    return (size_t)GetVirtualTransactionSize(GetTransactionInputWeight(tx_in), 0, 0);

l0rinc commented at 2:42 PM on October 30, 2026:

nit: seems like an inline instead of a remove

l0rinc approved
l0rinc commented at 2:44 PM on October 30, 2026: contributor

lightly tested code review ACK 3e2cf63da5090d59218c66dcc9a54c0f8c67e648
jpk68 commented at 8:02 PM on October 30, 2026: contributor

ACK 3e2cf63da5090d59218c66dcc9a54c0f8c67e648

Contributors

Labels

Linked (view graph)

#26567 Wallet: estimate the size of signed inputs using descriptors

policy: remove unused GetVirtualTransactionInputSize #36706

External sites

Reviews

LLM Linter (✨ experimental)