With these removed, WaitForDataOrEof and the condition variable are also removed.
This was merged as part of #30205, in advance of #26812, which never landed.
test: remove unused `DynSock::Pipe::GetNetMsg` and `PushNetMsg` #36713
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_dynsock_netmsg changing 2 files +3 −97-
fanquake commented at 5:12 PM on October 30, 2026: member
- DrahtBot added the label Tests on Oct 30, 2026
-
DrahtBot commented at 5:12 PM on October 30, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36713
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36713.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36713#author-ralph
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process.
Type Reviewers ACK jpk68, willcl-ark, sedited If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
e172eb69df
test: remove unused DynSock::Pipe::GetNetMsg and PushNetMsg
With these removed, WaitForDataOrEof and the condition variable are also removed.
- fanquake force-pushed on Oct 30, 2026
- DrahtBot added the label CI failed on Oct 30, 2026
- DrahtBot removed the label CI failed on Oct 30, 2026
-
jpk68 commented at 8:01 PM on October 30, 2026: contributor
ACK e172eb69df92b5ef9cd5f4234de28430c1f7b7b8
- fanquake requested review from willcl-ark on Nov 5, 2026
- willcl-ark approved
-
willcl-ark commented at 8:44 AM on November 6, 2026: member
utACK e172eb69df92b5ef9cd5f4234de28430c1f7b7b8
Nice cleanup that also removes (some tiny) unnecessary notification overhead.
Removing the unused blockign read path lets us drop the condition variable and its notifications from writes and EOF handling.
Using
LOCKalso makes it clearer thatGetBytes()takes the mutex without waiting for data. - sedited approved
-
sedited commented at 12:27 PM on November 6, 2026: contributor
Reproduced ACK e172eb69df92b5ef9cd5f4234de28430c1f7b7b8
I think if we ever want this back again in the tests, this seems straight forward enough to add back.
- sedited merged this on Nov 6, 2026
- sedited closed this on Nov 6, 2026
- fanquake deleted the branch on Nov 6, 2026
