test: Use `contains` in miniminer_tests #36754

pull rustaceanrob wants to merge 1 commits into bitcoin:master from rustaceanrob:nov-4-mini-miner-tests changing 1 files +2 −2
  1. rustaceanrob commented at 2:23 PM on November 4, 2026: member

    These tests use count which is then cast to a boolean, but we can check contains here directly. This is a tidy failure in #35713 but it seems fine to update here regardless of what happens with #35713.

  2. test: Use `contains` in miniminer_tests
    These tests use `count` which is then cast to a boolean, but we can
    check `contains` here directly. This is a tidy failure in 35713 but it
    seems fine to update here regardless of what happens with 35713.
    158a9868f5
  3. DrahtBot added the label Tests on Nov 4, 2026
  4. DrahtBot commented at 2:26 PM on November 4, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. fanquake commented at 3:04 PM on November 4, 2026: member

    ACK 158a9868f5395cb3761a61adfabf73a768b67a93

  6. sedited approved
  7. sedited commented at 3:06 PM on November 4, 2026: contributor

    ACK 158a9868f5395cb3761a61adfabf73a768b67a93

  8. fanquake merged this on Nov 4, 2026
  9. fanquake closed this on Nov 4, 2026

  10. l0rinc commented at 4:37 PM on November 4, 2026: contributor

    post merge ACK 158a9868f5395cb3761a61adfabf73a768b67a93

    The count refers to a set where the it is analogous to the contains method. Seems like a leftover after #33192 was trimmed to avoid conflicts.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-18 16:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me