These tests use count which is then cast to a boolean, but we can check contains here directly. This is a tidy failure in #35713 but it seems fine to update here regardless of what happens with #35713.
test: Use `contains` in miniminer_tests #36754
pull rustaceanrob wants to merge 1 commits into bitcoin:master from rustaceanrob:nov-4-mini-miner-tests changing 1 files +2 −2-
rustaceanrob commented at 2:23 PM on November 4, 2026: member
-
158a9868f5
test: Use `contains` in miniminer_tests
These tests use `count` which is then cast to a boolean, but we can check `contains` here directly. This is a tidy failure in 35713 but it seems fine to update here regardless of what happens with 35713.
- DrahtBot added the label Tests on Nov 4, 2026
-
DrahtBot commented at 2:26 PM on November 4, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36754
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36754.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36754#author-ralph
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
fanquake commented at 3:04 PM on November 4, 2026: member
ACK 158a9868f5395cb3761a61adfabf73a768b67a93
- sedited approved
-
sedited commented at 3:06 PM on November 4, 2026: contributor
ACK 158a9868f5395cb3761a61adfabf73a768b67a93
- fanquake merged this on Nov 4, 2026
- fanquake closed this on Nov 4, 2026
Contributors
Labels