test: Fix log and comment in mempool_reorg.py #36770

pull Waridi318 wants to merge 1 commits into bitcoin:master from Waridi318:test-mempool-reorg-nits changing 1 files +1 −2
  1. Waridi318 commented at 8:56 AM on November 5, 2026: contributor

    Follow-up to #36663. These two pre-existing nits came up in review there and were left out of that PR to avoid review churn (comment).

    Remove the "Generate a block" log line in test_reorg. It adds nothing and causes confusion. The log line above it already says "Broadcast and mine spend_3_1" and the mining only happens a few lines later in self.generate(self.nodes[0], FORK_LENGTH - 1).

    Update the comment "Create a child of that transaction" in test_reorg_relay. It sits right below tx_before_reorg, so it suggests the child spends tx_before_reorg. The child actually spends tx_disconnected, so name it explicitly.

    Only a log message and a comment change, so test behavior is unchanged. mempool_reorg.py passes locally.

  2. test: Fix log and comment in mempool_reorg.py
    Remove the "Generate a block" log line in test_reorg. It adds nothing
    and causes confusion. The log line above it already says "Broadcast
    and mine spend_3_1", and the mining only happens a few lines later in
    self.generate(self.nodes[0], FORK_LENGTH - 1).
    
    Update the comment "Create a child of that transaction" in
    test_reorg_relay. It sits right below tx_before_reorg, so it suggests
    the child spends tx_before_reorg. The child actually spends
    tx_disconnected, so name it explicitly.
    2438fbcade
  3. DrahtBot added the label Tests on Nov 5, 2026
  4. DrahtBot commented at 8:56 AM on November 5, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK maflcko, mercie-ux

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. maflcko commented at 9:06 AM on November 5, 2026: member

    lgtm ACK 2438fbcade95e695f5b90043e9694ffc182a7e5c

  6. DrahtBot added the label CI failed on Nov 5, 2026
  7. maflcko commented at 10:08 AM on November 5, 2026: member

    Ci failure Download failed: HTTP Error 504: Gateway Time-out can be ignored, this is just a doc-only change

  8. Waridi318 commented at 10:11 AM on November 5, 2026: contributor

    Ci failure Download failed: HTTP Error 504: Gateway Time-out can be ignored, this is just a doc-only change

    Thanks for checking!

  9. mercie-ux commented at 10:33 AM on November 5, 2026: contributor

    ACK 2438fbcade95e695f5b90043e9694ffc182a7e5c

    The "Generate a block" log went stale in 70d9e8f0a1, which removed the generate(self.nodes[0], 1) call that used to follow it, so removing it looks like the right fix.

  10. fanquake merged this on Nov 5, 2026
  11. fanquake closed this on Nov 5, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-14 11:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me