Includes:
Used in #36623.
Update minisketch subtree to latest master #36783
pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:update_minisketch_subtree changing 1 files +0 −1-
fanquake commented at 4:43 PM on November 5, 2026: member
-
be064af99d
Squashed 'src/minisketch/' changes from a12f5de1c9..d44dca4e3f
d44dca4e3f Merge sipa/minisketch#106: refactor: remove unreachable code 75488667cd refactor: remove unreachable code git-subtree-dir: src/minisketch git-subtree-split: d44dca4e3f64a8db6335e444fdbb6da2d15a028b
-
Update minisketch subtree to latest upstream 828ba5a3ba
-
DrahtBot commented at 4:43 PM on November 5, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36783
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36783.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36783#author-ralph
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process.
Type Reviewers ACK willcl-ark, sedited If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
willcl-ark commented at 10:27 AM on November 6, 2026: member
Similar to #36623, I had a clanker compare compiled objects before and after this change. They were byte-identical with GCC and Clang at both -O0 and -O2, both with CLMUL enabled and disabled.
https://gist.github.com/willcl-ark/00137991ffe05144cab2bb4049ef7451
- willcl-ark approved
-
willcl-ark commented at 10:32 AM on November 6, 2026: member
utACK 828ba5a3ba4ccd8bfc8a17ad0fcd3f0b99a0c8c3
Every branch of the inner switch, including default, returns. The deleted break therefore cannot execute.
Compiled objects were cross-checked in an earlier comment, but I ran no further tests.
- sedited approved
-
sedited commented at 10:48 AM on November 6, 2026: contributor
ACK 828ba5a3ba4ccd8bfc8a17ad0fcd3f0b99a0c8c3
- sedited merged this on Nov 6, 2026
- sedited closed this on Nov 6, 2026
- fanquake deleted the branch on Nov 6, 2026
