rpc: wallet: Add snake_case aliases for listunspent options #36785

maflcko commented at 7:08 PM on November 5, 2026: member

This concludes the snake_case aliases for all wallet option objects or named args.

Deprecation can be done in the future, in a few releases.

DrahtBot renamed this:
~~rpc: wallet: Add snake_case aliases for listunspent options~~
rpc: wallet: Add snake_case aliases for listunspent options
on Nov 5, 2026

DrahtBot added the label RPC/REST/ZMQ on Nov 5, 2026

DrahtBot commented at 7:08 PM on November 5, 2026: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

External sites

Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36785
Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36785.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36785#author-ralph

Reviews

See the guideline and AI policy for information on the review process.

Type	Reviewers
ACK	Zippo76, willcl-ark

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#36743 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/36743.svg"></sub> ([RFC] build: build with -Wmissing-declarations/prototypes by fanquake)
#35302 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/35302.svg"></sub> (Silent Payments: Sending (take 2) by Eunovo)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

rpc: wallet: Add snake_case aliases for listunspent options

And use it in one test.

fab4cb51b4

refactor: Re-use a single GetOptionWithAlias

This does not change any behavior, but makes possible future deprecation
easier.

facf53acf4

maflcko force-pushed on Nov 5, 2026

DrahtBot added the label CI failed on Nov 5, 2026

maflcko commented at 7:16 PM on November 5, 2026: member

<details><summary>rendered schema and doc diff</summary>

diff --git a/getopenrpcinfo.full.json b/getopenrpcinfo.full.json
index ee8225f..1e3d368 100644
--- a/getopenrpcinfo.full.json
+++ b/getopenrpcinfo.full.json
@@ -11685 +11685 @@
-                            "minimumAmount": {
+                            "minimum_amount": {
@@ -11697 +11697 @@
-                            "maximumAmount": {
+                            "maximum_amount": {
@@ -11709 +11709 @@
-                            "maximumCount": {
+                            "maximum_count": {
@@ -11714 +11714 @@
-                            "minimumSumAmount": {
+                            "minimum_sum_amount": {
diff --git a/listunspent b/listunspent
index 0fe30b3..cde15ac 100644
--- a/listunspent
+++ b/listunspent
@@ -20,4 +20,4 @@ Named Arguments:
-minimumAmount                (numeric or string, optional, default="0.00") Minimum value of each UTXO in BTC
-maximumAmount                (numeric or string, optional, default=unlimited) Maximum value of each UTXO in BTC
-maximumCount                 (numeric, optional, default=unlimited) Maximum number of UTXOs
-minimumSumAmount             (numeric or string, optional, default=unlimited) Minimum sum value of all UTXOs in BTC
+minimum_amount               (numeric or string, optional, default="0.00") Minimum value of each UTXO in BTC
+maximum_amount               (numeric or string, optional, default=unlimited) Maximum value of each UTXO in BTC
+maximum_count                (numeric, optional, default=unlimited) Maximum number of UTXOs
+minimum_sum_amount           (numeric or string, optional, default=unlimited) Minimum sum value of all UTXOs in BTC
@@ -60,2 +60,2 @@ Examples:
-> bitcoin-cli listunspent 6 9999999 '[]' true '{ "minimumAmount": 0.005 }'
-> curl --user myusername --data-binary '{"jsonrpc": "2.0", "id": "curltest", "method": "listunspent", "params": [6, 9999999, [] , true, { "minimumAmount": 0.005 } ]}' -H 'content-type: application/json' http://127.0.0.1:8332/
+> bitcoin-cli listunspent 6 9999999 '[]' true '{ "minimum_amount": 0.005 }'
+> curl --user myusername --data-binary '{"jsonrpc": "2.0", "id": "curltest", "method": "listunspent", "params": [6, 9999999, [] , true, { "minimum_amount": 0.005 } ]}' -H 'content-type: application/json' http://127.0.0.1:8332/

</details>

DrahtBot removed the label CI failed on Nov 5, 2026

fanquake added this to the milestone 33.0 on Nov 6, 2026

fanquake commented at 10:44 AM on November 6, 2026: member

Put this on 33.0 given #36489 is already in. Should do this all in one cycle.

Zippo76 commented at 9:31 PM on November 9, 2026: none

tACK facf53acf4

Tested on macOS 27.2 arm64 against master 4ef7904c39. The modified wallet_listtransactions.py test fails on master with Unknown named parameter minimum_amount and passes with this PR. Manually checked all four aliases, both inside query_options and via bitcoin-cli -named. Each produces the same filtering results as its camelCase counterpart. Supplying both spellings is rejected in both forms. In query_options, the error says “Do not set both.” With -named, it reports “Unknown named parameter” for the camelCase alias, consistent with the generic named-argument handling already used by existing aliases.

snake_case          camelCase         query_options  -named  both spellings
minimum_amount      minimumAmount     same results   same    rejected
maximum_amount      maximumAmount     same results   same    rejected
maximum_count       maximumCount      same results   same    rejected
minimum_sum_amount  minimumSumAmount  same results   same    rejected

Also checked fundrawtransaction with change_position and changePosition: behaviour matches master, including the error when both are supplied.

fanquake requested review from willcl-ark on Nov 10, 2026

willcl-ark approved

willcl-ark commented at 2:52 PM on November 10, 2026: member

ACK facf53acf43cb392d3af72ef837a4b825ed31406

fanquake merged this on Nov 10, 2026

fanquake closed this on Nov 10, 2026