refactor: more prereqs for #36743 #36813

pull fanquake wants to merge 6 commits into bitcoin:master from fanquake:more_36743_split changing 26 files +342 −409

fanquake commented at 12:55 PM on November 9, 2026: member

Some more changes split out of #36743.
rest: include httprpc.h for StartREST, InterruptREST and StopREST 30a6c6e55a

qt: declare ForceActivation in macdockiconhandler.h

It was declared locally in guiutil.cpp, so the definition was never
checked against the declaration.

36763783e9

rpc: declare getblockchaininfo and getdeploymentinfo in rpc/blockchain.h 2bfa8bfeaf
refactor: make functions only used in their own translation unit static
Drop their header declarations.
1a3ecfdfb4
refactor: make forward-declared translation unit local functions static
Also drop the forward declarations, reordering definitions where needed.
9cd113d615

refactor: make same-named functions in different files static

CombineSignatures, CreateTestBlock and hex_string_to_byte_vec are each
defined in two files.

8d3049d679

DrahtBot added the label Refactoring on Nov 9, 2026
DrahtBot commented at 12:55 PM on November 9, 2026: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36813
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36813.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36813#author-ralph


Reviews

See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

Contributors

Labels