Draft for now, as it requires upstream changes, and some codebase/style decisions. Some of the fixes will be split off in advance.
Based on:
Draft for now, as it requires upstream changes, and some codebase/style decisions. Some of the fixes will be split off in advance.
Based on:
The header declared AddInputs(..., bool rbf), which was never defined,
while the definition takes std::optional<bool> and has no declaration.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
These were declared in fa6b061fc1 but never defined or used.
The definitions were removed in 43c1f5b8d7, but the declarations were
left behind.
Match the definition, and the m_idle_since member.
These functions are only used within the file that defines them, and
have no declaration elsewhere, so -Wmissing-prototypes (clang) and
-Wmissing-declarations (GCC) warn about them. Give them internal
linkage.
fail_test_if_executed() is [[maybe_unused]], because TRACEPOINT discards
its arguments when tracing is disabled.
LLVMFuzzerTestOneInput and LLVMFuzzerInitialize are called by libFuzzer,
so they can't be static. Declare them first, to avoid
-Wmissing-prototypes / -Wmissing-declarations warnings.
This is GCC's equivalent of clang's -Wmissing-prototypes for C++.
It was declared locally in guiutil.cpp, so the definition was never
checked against the declaration.