Why were tests using CreateSyncedWallet() passing before this change?
I'm not sure what you mean. It didn't change any behaviour because CreateSyncedWallet() used to create a wallet just like NewWallet() but now it reuses the NewWallet() to deduplicate code.
I think the interface for NewWallet is a little better taking the node argument
At first I thought passing chain makes more sense for a wallet function but with your comment I realized it doesn't matter much and the benefits of passing node context directly are better. Done on 5b70468637e00349ec9a7be35c84995f405a91e0.