guix: backport oscrypto PBKDF2 timing fix #36838

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2026/11/guix-oscrypto-timing changing 2 files +42 −1
  1. Sjors commented at 2:59 PM on November 11, 2026: member

    With substitutes disabled, guix-codesign can fail when building oscrypto 1.3.0. The test_dump_private test raises ZeroDivisionError.

    The Guix time-machine bump in bitcoin/bitcoin#36233 (merged after the 32.x branch-off) pulls in OpenSSL 3.5.5, which can finish oscrypto's initial PBKDF2 benchmark in under a millisecond. oscrypto truncates this duration to zero and then divides by it. This was fixed upstream in wbond/oscrypto@144c12195001b08b9ccecb8a3fd041d22ae24474

    This PR adds the fix to contrib/guix/patches. It can be dropped once a new oscrypto release includes the fix and a Guix time machine bump includes it.

  2. guix: backport oscrypto PBKDF2 timing fix
    With substitutes disabled, guix-codesign can fail when building oscrypto
    1.3.0. The test_dump_private test raises ZeroDivisionError.
    
    The Guix time-machine bump in bitcoin/bitcoin#36233 pulls in OpenSSL
    3.5.5, which can finish oscrypto's initial PBKDF2 benchmark in under a
    millisecond. oscrypto truncates this duration to zero and then divides
    by it.
    
    Apply the upstream fix:
    wbond/oscrypto@144c12195001b08b9ccecb8a3fd041d22ae24474
    a97c4b0289
  3. DrahtBot added the label Build system on Nov 11, 2026
  4. DrahtBot commented at 2:59 PM on November 11, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. Sjors commented at 3:05 PM on November 11, 2026: member

    I ran into this while making a new release for sv2-tp, which backports most recent tool-changes from here.

    I used local-file instead of search-our-patches. I can add a commit to drop that helper entirely if people want: https://github.com/Sjors/bitcoin/commit/95098e4587ebb158881b180b4a1aa0468a6bc6ce

Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-16 00:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me