iwyu: Fix warnings in some modules in `src/` and treat them as errors #36844

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:261112-iwyu-src changing 20 files +97 −28
  1. hebasto commented at 10:27 AM on November 12, 2026: member

    Split from #36808.

    This PR fixes includes in some files in the src/ directory, as needed for #36808. Its scope is intentionally limited to minimize potential merge conflicts.

    The changes outside src/ add headers that were previously included transitively.

  2. ci, refactor: List top-level IWYU-enforced files one per line
    This makes the list easier to read and extend, and keeps diffs
    minimal when files are added.
    47e41ed58a
  3. iwyu: Fix warnings in some modules in `src/` and treat them as errors
    The changes in other files add headers that were previously included
    transitively.
    cc39f15ceb
  4. DrahtBot commented at 10:27 AM on November 12, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #36843 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/36843.svg"></sub> (scripted-diff: [test] Add util/check.h includes for assertions by maflcko)
    • #35642 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/35642.svg"></sub> (headersync: do parameter search at runtime by sipa)
    • #35229 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/35229.svg"></sub> (refactor: Use CBlockIndex parameters as reference by optout21)
    • #31260 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/31260.svg"></sub> (scripted-diff: Type-safe settings retrieval by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-14 18:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me