test: remove unused nodes and restarts from wallet tests #36868

pull w0xlt wants to merge 3 commits into bitcoin:master from w0xlt:test-wallet-unused-nodes changing 4 files +24 −32
  1. w0xlt commented at 7:08 AM on November 14, 2026: contributor

    Some wallet functional tests start or restart nodes they never use:

    • wallet_basic.py: node 3 hasn't been used since the resendwallettransactions check was removed in 2019 (f5162458cd), but the test still starts, stops and restarts it. Without it, the sync calls no longer need self.nodes[0:3].

    • wallet_signrawtransactionwithwallet.py and wallet_derivehdkey.py each start a second node that is never used.

    • wallet_sendall.py restarts node 0 and reloads its wallets twice in a row with the same arguments.

    No coverage changes. Each test runs a bit faster, about 0.2–0.4 s per test locally.

  2. test: remove unused node from wallet_basic
    Node 3 was last used by the resendwallettransactions check, which was
    removed together with the RPC in f5162458cd. Since then the test only
    starts, connects and syncs it, and never checks anything on it.
    
    Drop it, and use the default sync now that all nodes take part, instead
    of passing self.nodes[0:3].
    4f0d4e11c1
  3. test: use one node in signrawtransactionwithwallet and derivehdkey
    Neither test uses its second node. wallet_signrawtransactionwithwallet
    stopped using node1 when the key-based cases moved to
    rpc_signrawtransactionwithkey.py in 0ee43d13e9, and wallet_derivehdkey
    never used it.
    0ba20992e8
  4. test: remove duplicate restart from wallet_sendall
    sendall_fails_when_bump_fees_exceed_maxtxfee restarts node 0 and
    reloads the wallets twice in a row with the same arguments. The second
    restart does nothing.
    afbe6cd25e
  5. DrahtBot added the label Tests on Nov 14, 2026
  6. DrahtBot commented at 7:08 AM on November 14, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #36387 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/36387.svg"></sub> (wallet: rpc: Deprecate encryptwallet RPC for encrypting existing wallets. by davidgumberg)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  7. fanquake commented at 9:21 AM on November 14, 2026: member
  8. ViniciusCestarii commented at 1:37 PM on November 14, 2026: contributor

    tACK afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3

    Verified that this doesn't change behavior. wallet_basic.py looks cleaner and it gives a small performance boost.

  9. adezo24h1 commented at 9:51 PM on November 14, 2026: none

    tACK afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3

  10. brunoerg approved
  11. brunoerg commented at 2:15 PM on November 16, 2026: contributor

    code review ACK afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3

  12. murchandamus commented at 9:32 PM on November 16, 2026: member

    ACK afbe6cd25ef72a7975c406ae8e036b30fb2e1ce3


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-18 16:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me