Update secp256k1 subtree to latest master #36890

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:261116-update-secp changing 30 files +782 −425
  1. hebasto commented at 3:27 PM on November 16, 2026: member

    This PR updates the libsecp256k1 subtree to https://github.com/bitcoin-core/secp256k1/commit/a0e2e23a71bf2aaae910f81cb2bd8aa0ae49d544, which includes the following changes:

    • bitcoin-core/secp256k1#1893
    • bitcoin-core/secp256k1#1935
    • bitcoin-core/secp256k1#1918
    • bitcoin-core/secp256k1#1840
    • bitcoin-core/secp256k1#1934
    • bitcoin-core/secp256k1#1942
    • bitcoin-core/secp256k1#1947
    • bitcoin-core/secp256k1#1948
    • bitcoin-core/secp256k1#1949
    • bitcoin-core/secp256k1#1933
    • bitcoin-core/secp256k1#1946
    • bitcoin-core/secp256k1#1950
    • bitcoin-core/secp256k1#1953
    • bitcoin-core/secp256k1#1963
    • bitcoin-core/secp256k1#1866
    • bitcoin-core/secp256k1#1929
    • bitcoin-core/secp256k1#1943
    • bitcoin-core/secp256k1#1952
    • bitcoin-core/secp256k1#1965
    • bitcoin-core/secp256k1#1975
    • bitcoin-core/secp256k1#1961
    • bitcoin-core/secp256k1#1978
    • bitcoin-core/secp256k1#1937
    • bitcoin-core/secp256k1#1983
    • bitcoin-core/secp256k1#1974
    • bitcoin-core/secp256k1#1986
    • bitcoin-core/secp256k1#1992
    • bitcoin-core/secp256k1#1972
    • bitcoin-core/secp256k1#1995
    • bitcoin-core/secp256k1#1999
    • bitcoin-core/secp256k1#1898
    • bitcoin-core/secp256k1#1998

    The update is prompted by new warnings introduced in Clang 24. bitcoin-core/secp256k1#1998 fixed them in the secp256k1 subtree. A fix for Bitcoin Core is here: #36869.

  2. Squashed 'src/secp256k1/' changes from a7f264373e..a0e2e23a71
    a0e2e23a71 Merge bitcoin-core/secp256k1#1998: Avoid unsequenced accesses to volatile variables
    e7a34ba3ec Avoid unsequenced accesses to volatile variables
    709e39c2fb refactor: Prefix volatile variable names with "v"
    5d2ff5365a Merge bitcoin-core/secp256k1#1898: tests: Silent Payments ctime test never reaches a match or label lookup
    a5cb9a3a05 Merge bitcoin-core/secp256k1#1999: modinv64: name mask1, not c1, in divsteps comment
    9b4c3a8676 modinv64: name mask1, not c1, in divsteps comment
    2e1e6c60e9 Merge bitcoin-core/secp256k1#1995: ci: Run the Wine jobs on ubuntu-24.04
    ecfe7ab8e4 ci: Run the Wine jobs on ubuntu-24.04
    f43a3453c3 Merge bitcoin-core/secp256k1#1972: tests: silentpayments: deduplicate setup code
    f391539a3b tests: cover Silent Payments label scanning
    078f67f86b tests: make Silent Payments ctime scan find output
    bf3160c802 Merge bitcoin-core/secp256k1#1992: doc: pass M, not Mi, to normalize in modinv_var
    f901165097 doc: pass M, not Mi, to normalize in modinv_var
    b97f7f5f9c Merge bitcoin-core/secp256k1#1986: examples: exit with failure if signature verification fails
    900613a742 examples: exit with failure if signature verification fails
    1c088b6486 Merge bitcoin-core/secp256k1#1974: silentpayments: reject label tweaks that overflow the group order
    95552e1654 silentpayments: reject label tweaks that overflow the group order
    a3a5cd45dc Merge bitcoin-core/secp256k1#1983: silentpayments: return 0 instead of `ARG_CHECK`ing for empty inputs/outputs
    160590d192 changelog: mention silentpayments returning 0 for empty inputs/outputs
    e7bb01121f silentpayments: allow NULL arrays in scan_outputs if n_tx_outputs is 0
    d7821f4adb silentpayments: return 0 instead of `ARG_CHECK`ing for empty inputs/outputs
    b88cbc7a65 Merge bitcoin-core/secp256k1#1937: tests: silentpayments: cover rejection of invalid keypair alongside a valid one
    1b4181f93f Merge bitcoin-core/secp256k1#1978: ci: Run ctime_tests in the arm64 Debian job
    95798f5f92 Merge bitcoin-core/secp256k1#1961: ci: run exhaustive_tests for group orders 7 and 199
    307035b302 Merge bitcoin-core/secp256k1#1975: ci: Run ctime_tests under Valgrind on arm64
    1c1d849491 ci: Run ctime_tests in the arm64 Debian job
    26299c7672 ci: Run ctime_tests under Valgrind on arm64
    70f321c334 tests: silentpayments: deduplicate prevouts summary setup
    67916d9bbc tests: silentpayments: deduplicate label cache setup
    9c6ece8bdd tests: silentpayments: deduplicate output tweak
    a3fcbeafe3 ci: run exhaustive_tests for group orders 7 and 199
    32099110d6 tests: don't define the ellswift exhaustive test for even-order curves
    e74a0187aa Merge bitcoin-core/secp256k1#1965: remove unused SECP256K1_GE_CONST_INFINITY
    d2cbca372a Merge bitcoin-core/secp256k1#1952: util: make STATIC_ASSERT usable at file scope
    60804dc2ec Merge bitcoin-core/secp256k1#1943: tests: silentpayments: cover labeled output beyond the first label batch
    7b59e1fc42 remove unused SECP256K1_GE_CONST_INFINITY
    04b91ce295 Merge bitcoin-core/secp256k1#1929: silentpayments: perform tweak addition with actual scalars
    0283a11d50 Merge bitcoin-core/secp256k1#1866: musig: Add hash context tests
    31716e4bb6 Merge bitcoin-core/secp256k1#1963: doc: say the sha256 compression callback processes secrets
    494d3053c0 doc: say the sha256 compression callback processes secrets
    0c3c70d5f7 tests: silentpayments: cover labeled output beyond the first label batch
    22245aedf4 Merge bitcoin-core/secp256k1#1953: ci: bump macOS ARM64 runner to macos-15
    146def9812 ci: bump macOS ARM64 runner to macos-15
    186eec1c1b Merge bitcoin-core/secp256k1#1950: tests: silentpayments: check found outputs are distinct in vector tests
    d6ec1ab4da tests: silentpayments: cover rejection of invalid keypair alongside a valid one
    1c6f793084 tests: silentpayments: check found outputs are distinct in vector tests
    6f065e9ad2 Merge bitcoin-core/secp256k1#1946: doc: clean up lingering ECMULT_WINDOW_SIZE comment
    20fcbae219 assumptions: move static assertions to file scope
    7d53109b85 util: make STATIC_ASSERT usable at file scope
    685247a381 doc: correct ecmult table storage size
    2365dc6455 Merge bitcoin-core/secp256k1#1933: refactor: introduce `ecmult_const_ge` helper (preventing accidential gej leaks)
    4a264a935a Merge bitcoin-core/secp256k1#1949: ecdsa: Clarify derivation of the r check in `_sig_verify`
    e23e92013c Merge bitcoin-core/secp256k1#1948: tests: add ECDSA verify case where r + n overflows p
    fc88acc3e2 tests: add ECDSA verify case where r + n overflows p
    93987567a1 ecdsa: Clarify derivation of the r check in `_sig_verify`
    2b4a7b906f Merge bitcoin-core/secp256k1#1947: musig: test nonce_gen_counter with random counters
    b819a790f0 musig: test nonce_gen_counter with random counters
    cc0e03ffd4 doc: clean up lingering ECMULT_WINDOW_SIZE comment
    f14d299258 Merge bitcoin-core/secp256k1#1942: unit_test: fix help text claiming unknown args are ignored
    9495f867e7 unit_test: fix help text claiming unknown args are ignored
    b63c6afb99 Merge bitcoin-core/secp256k1#1934: Clear secret-dependent variables in `_ecmult_const_xonly`
    9701113f31 Merge bitcoin-core/secp256k1#1840: ci: Simplify module configuration and extend test coverage
    fac66a1b4e musig: add hash context tests
    46db787112 Merge bitcoin-core/secp256k1#1918: refactor: split `ge_parse` into explicit variants (compressed, uncompressed, uncompressed+hybrid)
    de02108c51 tests: cover compressed pubkey parsing/serialization in `_ec_pubkey_parse` test
    d01de27144 Merge bitcoin-core/secp256k1#1935: tests: generate scalars_near_split_bounds instead of hardcoding
    31b1b300e8 refactor: split `ge_parse` helper into explicit variants
    014825f0a3 tests: generate scalars_near_split_bounds instead of hardcoding
    9e65f6ac9b Clear secret-dependent variables in `_ecmult_const_xonly`
    02e00f54a0 test: refactor: simplify tests by using `_ecmult_const_ge` helper
    b4fbee61e9 refactor: rename `_ecmult_const` -> `_ecmult_const_gej` for consistency
    ace566f66c refactor: introduce `_ecmult_const_ge` helper (preventing accidental gej leaks)
    99ae231231 Merge bitcoin-core/secp256k1#1893: test: cover schnorrsig_sign_custom in constant-time tests
    38255a943f test: cover custom Schnorr nonce callback in ctime tests
    2a3780d73f test: cover schnorrsig_sign_custom in constant-time tests
    11e9c6ede7 silentpayments: perform tweak addition with actual scalars
    63f7e222c9 ci: Simplify module configuration
    
    git-subtree-dir: src/secp256k1
    git-subtree-split: a0e2e23a71bf2aaae910f81cb2bd8aa0ae49d544
    cbe152cfb5
  3. Update secp256k1 subtree to latest master acb8f2b9d2
  4. DrahtBot commented at 3:28 PM on November 16, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    Concept ACK theStack

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #36122 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/36122.svg"></sub> (BIP460: CISA for Taproot key path spends by fjahr)
    • #29491 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/29491.svg"></sub> ([EXPERIMENTAL] Schnorr batch verification for blocks by fjahr)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. theStack commented at 4:47 PM on November 16, 2026: contributor
  6. hebasto commented at 5:40 PM on November 16, 2026: member

    My Guix build:

    $ uname -m && find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
    aarch64
    6580ababcf0af392313d23ed365932445a82efb5e98c2e9d7d15218ebc0a455c  guix-build-acb8f2b9d26f/output/aarch64-linux-gnu/SHA256SUMS.part
    3522321448498d0cc05aef2c1dc649c0d332ac657c17cfc2ff8bb552f62fa375  guix-build-acb8f2b9d26f/output/aarch64-linux-gnu/bitcoin-acb8f2b9d26f-aarch64-linux-gnu-debug.tar.gz
    5b3f42c42aaa911645e6004fa0a27c392828153f888e8b7f454e1c3cdc61495e  guix-build-acb8f2b9d26f/output/aarch64-linux-gnu/bitcoin-acb8f2b9d26f-aarch64-linux-gnu.tar.gz
    bee2055d8cba38683893de46e6162d04d0ef7e08a24f91660a95ed3c04a29f97  guix-build-acb8f2b9d26f/output/arm-linux-gnueabihf/SHA256SUMS.part
    8f08e9903dcac847ae60a8dece43bb11aecd88690d18555419467a4f59507f87  guix-build-acb8f2b9d26f/output/arm-linux-gnueabihf/bitcoin-acb8f2b9d26f-arm-linux-gnueabihf-debug.tar.gz
    755ad60980e557a55522d2e3dd956b0e99fc106e2d8438dd29d45272a576689d  guix-build-acb8f2b9d26f/output/arm-linux-gnueabihf/bitcoin-acb8f2b9d26f-arm-linux-gnueabihf.tar.gz
    adc5655577cc5b5c608346b4684fbb761f7b3d20a3b601c1836788375cbacf87  guix-build-acb8f2b9d26f/output/arm64-apple-darwin/SHA256SUMS.part
    daab44acc7447df5733d0e8343a07c56437c1df3eeab01dce724bab1cb8b73aa  guix-build-acb8f2b9d26f/output/arm64-apple-darwin/bitcoin-acb8f2b9d26f-arm64-apple-darwin-codesigning.tar.gz
    22fa2225badd2cabcbed81c872c06968cbfa9bdbe4e5f1070747253397615f2b  guix-build-acb8f2b9d26f/output/arm64-apple-darwin/bitcoin-acb8f2b9d26f-arm64-apple-darwin-unsigned.tar.gz
    0d7ea82ab4dd1febeef2ff1002e0e3a6d9deab972c68424afca9047b2edf991d  guix-build-acb8f2b9d26f/output/arm64-apple-darwin/bitcoin-acb8f2b9d26f-arm64-apple-darwin-unsigned.zip
    27587f4b585006f93dfd2970d817059a3647124273621c04903def4c1fe52e94  guix-build-acb8f2b9d26f/output/dist-archive/bitcoin-acb8f2b9d26f.tar.gz
    f4aa65dc7499f32642c02b65e46faa18193341b8e1449711d137ccb6fa404cf9  guix-build-acb8f2b9d26f/output/powerpc64-linux-gnu/SHA256SUMS.part
    0adc28eca66500d639ec6afa40ef79dff3750e44e35afbb1449a81ab418e7c4b  guix-build-acb8f2b9d26f/output/powerpc64-linux-gnu/bitcoin-acb8f2b9d26f-powerpc64-linux-gnu-debug.tar.gz
    9d8e933ce8c61150a91f0466c83f669ae6282613ae40d7f9f2eb57b80e8ff88a  guix-build-acb8f2b9d26f/output/powerpc64-linux-gnu/bitcoin-acb8f2b9d26f-powerpc64-linux-gnu.tar.gz
    adc7560f28d120f9d9299ff47709bc91ed15d6858f6f096bdaa10660827ceca2  guix-build-acb8f2b9d26f/output/riscv64-linux-gnu/SHA256SUMS.part
    85b9212b1ae52a8ff3035bc826ec23033d3067253518f52f682fb468a8f3b6b4  guix-build-acb8f2b9d26f/output/riscv64-linux-gnu/bitcoin-acb8f2b9d26f-riscv64-linux-gnu-debug.tar.gz
    ad462d710bacbef117a3a78461dca69e0addeb6a61c9dbaac5bc08f22ee444e7  guix-build-acb8f2b9d26f/output/riscv64-linux-gnu/bitcoin-acb8f2b9d26f-riscv64-linux-gnu.tar.gz
    e67f3260439e216382d289bbf44b7af2f9eee071fc601e213076b148475b5894  guix-build-acb8f2b9d26f/output/x86_64-apple-darwin/SHA256SUMS.part
    a47b603d91e2dadb509435e45937f179c5a4a8200102ab31aa6d8c652c35f195  guix-build-acb8f2b9d26f/output/x86_64-apple-darwin/bitcoin-acb8f2b9d26f-x86_64-apple-darwin-codesigning.tar.gz
    5538017bd619e4958e520a80e49dc9d2e9867abb7c5d9b5c5e3b7861b0b4679c  guix-build-acb8f2b9d26f/output/x86_64-apple-darwin/bitcoin-acb8f2b9d26f-x86_64-apple-darwin-unsigned.tar.gz
    ccfe1445fd0d7142e3238334071fedc306eca712812d37937690cfb230aad5b1  guix-build-acb8f2b9d26f/output/x86_64-apple-darwin/bitcoin-acb8f2b9d26f-x86_64-apple-darwin-unsigned.zip
    97d6eb1267f6d0029701832815401901b44d4155630d1f824a05d53d9a4d6bf1  guix-build-acb8f2b9d26f/output/x86_64-linux-gnu/SHA256SUMS.part
    fcbd31a3f4db281bf2a4023f9b65abc8d600550f66b326a8ae620ef7ae008007  guix-build-acb8f2b9d26f/output/x86_64-linux-gnu/bitcoin-acb8f2b9d26f-x86_64-linux-gnu-debug.tar.gz
    a8cae1ffbab8ce98ab5576c1c853f1e3e61f1e501df51acfaa6b693a95877942  guix-build-acb8f2b9d26f/output/x86_64-linux-gnu/bitcoin-acb8f2b9d26f-x86_64-linux-gnu.tar.gz
    383da723447db310e54134b4cdb215d4e0b5b3da0b00c4ff817706236fa30848  guix-build-acb8f2b9d26f/output/x86_64-w64-mingw32/SHA256SUMS.part
    79d19435bad81519b1a48cfbd88253b564167f811bcb5f6c931cca41d6e14b24  guix-build-acb8f2b9d26f/output/x86_64-w64-mingw32/bitcoin-acb8f2b9d26f-win64-codesigning.tar.gz
    8a03c89c83f780e411c751337ffdc41f9c4fe04e3a1d1f00d2296c49454d5d89  guix-build-acb8f2b9d26f/output/x86_64-w64-mingw32/bitcoin-acb8f2b9d26f-win64-debug.zip
    ed9269c6ab120dbec3b75bd5fbc29b380006728e75b8e265e5b24e5f9bffc77c  guix-build-acb8f2b9d26f/output/x86_64-w64-mingw32/bitcoin-acb8f2b9d26f-win64-setup-unsigned.exe
    69846a221fa21995a72a5e977c4c12c867849a1d673b24cbb721db85321c3f20  guix-build-acb8f2b9d26f/output/x86_64-w64-mingw32/bitcoin-acb8f2b9d26f-win64-unsigned.zip
    
  7. fanquake commented at 10:28 AM on November 17, 2026: member
  8. hebasto commented at 10:48 AM on November 17, 2026: member

    Shouldn't this wait for bitcoin-core/secp256k1#1996?

    It's unclear when that PR will be reviewed and merged, so I'd rather not block on it. It can be picked up in the next subtree update once it lands.

  9. fanquake commented at 10:56 AM on November 17, 2026: member

    It's unclear when that PR will be reviewed and merged

    I'd assume soon, given it's going to start causing CI failures for us, and is already broken for anyone using CMake 4.5.0 and dev-mode locally? Otherwise I'm not clear what the rush is, to merge this, to then just have to pull again in a day or two to get the CMake fix.

  10. hebasto commented at 11:03 AM on November 17, 2026: member

    Sure. No rush at all.

  11. real-or-random commented at 12:40 PM on November 18, 2026: contributor

    It's unclear when that PR will be reviewed and merged

    I'd assume soon, given it's going to start causing CI failures for us, and is already broken for anyone using CMake 4.5.0 and dev-mode locally? Otherwise I'm not clear what the rush is, to merge this, to then just have to pull again in a day or two to get the CMake fix.

    I'll try to post a review of https://github.com/bitcoin-core/secp256k1/pull/1996 today.

    But if you want to speed this up, the thing that helps us is review from CMake experts. @hebasto is the only regular libsecp256k1 contributor who is deep into CMake (and he can't review his own PR). All I can do is stare at the diff, point my LLM to it, and run some testing to make sure the PR doesn't introduce any badness in the build. That's probably all we need for a build system PR but it's still hard for me to judge these PRs dealing with CMake specifics.

  12. maflcko commented at 9:50 AM on November 19, 2026: member

    I'll try to post a review of bitcoin-core/secp256k1#1996 today.

    But if you want to speed this up, the thing that helps us is review from CMake experts.

    Maybe @purpleKarrot can help?


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-19 19:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me