Add licensing to bitcoind unit tests #3848

issue dajohi opened this issue on March 11, 2014
  1. dajohi commented at 6:07 PM on March 11, 2014: contributor

    The current source files in test/ do not have a license, so they are fully copyrighted.

    I'd like to request MIT license be added so that other bitcoin implementations can use the same unit test values as the reference client.

  2. TheBlueMatt commented at 6:11 PM on March 11, 2014: member

    My contributions to bitcoin in that folder are licensed under MIT.

  3. gmaxwell commented at 6:11 PM on March 11, 2014: contributor

    I think this was the intention all along. I agree we should fix this.

    Git blame (for the json files) says for maximum prudence we should also get confirmation from CodeShark, gavinandresen, sipa, petertodd, wumpus, grau.

  4. sipa commented at 6:11 PM on March 11, 2014: member

    I agree with MIT license for these files.

  5. CodeShark commented at 6:11 PM on March 11, 2014: contributor

    confirmed

  6. sipa commented at 6:12 PM on March 11, 2014: member

    To be clear: gmaxwell's list of people only includes those who wrote json data for tests, not the tests themselves.

  7. vegard commented at 6:24 PM on March 11, 2014: contributor

    I'm fine with MIT license for all my contributions as well.

  8. jgarzik commented at 6:26 PM on March 11, 2014: contributor

    ACK MIT

  9. luke-jr commented at 6:37 PM on March 11, 2014: member

    ACK MIT

  10. petertodd commented at 6:54 PM on March 11, 2014: contributor

    ACK MIT

  11. gavinandresen commented at 6:58 PM on March 11, 2014: contributor

    ACK MIT. Or whatever. Do people really worry about stuff like this?

  12. laanwj commented at 8:04 PM on March 11, 2014: member

    ACK MIT

  13. luke-jr commented at 12:06 AM on March 12, 2014: member

    @gavinandresen People have to "worry" about stuff like this in most jurisdictions...

  14. gmaxwell commented at 12:11 AM on March 12, 2014: contributor

    @luke-jr No need to start an argument. Even if it's pointless to get confirmation, its stupidly cheap to do... and acts as a kind of group confirmation of conscientiousness: "We make an effort to produce software which is high quality in every way".

  15. Diapolo commented at 2:24 PM on March 12, 2014: none

    ACK

  16. dajohi commented at 5:17 PM on March 14, 2014: contributor

    I'd recommend a LICENSE file in src/test/data and

    <pre> // Copyright (c) 2009-2013 The Bitcoin developers // Distributed under the MIT/X11 software license, see the accompanying // file COPYING or http://www.opensource.org/licenses/mit-license.php. </pre>

    in the source files in src/test/ ?

  17. laanwj referenced this in commit 3fc6846181 on Mar 18, 2014
  18. gmaxwell closed this on Mar 18, 2014

  19. MathyV referenced this in commit 1acc4b820d on Oct 27, 2014
  20. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 18:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me