Change debug.log from UTC to localtime. Fixes #3872. #3983

pull bardiharborow wants to merge 1 commits into bitcoin:master from bardiharborow:issue3872 changing 1 files +1 −1

bardiharborow commented at 11:48 PM on March 30, 2014: contributor

I don't know if we actually want to change this, just preparing a commit just in case. We also may want to add a ISO 8601 +02:00 type thing, but I'm yet to work that out. I've tested and it seems localtime gives that same type of output as gmtime.

<b>EDIT: Do Not Merge! Creates wrong behaviour in EncodeDumpTime which relies on this being UTC.</b>
Change debug.log from UTC to localtime. Fixes #3872. 34b4eccdc3
gmaxwell commented at 11:55 PM on March 30, 2014: contributor

I don't think we want to change this. I've been happy that it was UTC time several times and I don't believe I've ever regretted it.
BitcoinPullTester commented at 12:10 AM on March 31, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/34b4eccdc37ababec3b9fc7333a4d33c42d17a05 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
bardiharborow commented at 12:54 AM on March 31, 2014: contributor

@gmaxwell, I think I've come to that conclusion too. UTC is nicer. I'll ask the owner of #3872 to close their issue.
bardiharborow closed this on Mar 31, 2014
bardiharborow deleted the branch on Mar 31, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

bardiharborow

gmaxwell

BitcoinPullTester