Reduce bignum.h now it is only needed for scriptnum_tests #4160

pull sipa wants to merge 2 commits into bitcoin:master from sipa:nobignumatall changing 8 files +182 −670

sipa commented at 3:40 PM on May 9, 2014: member

No description provided.
Reduce bignum.h now it is only needed for scriptnum_tests ccc84e0963
gmaxwell commented at 3:41 PM on May 9, 2014: contributor

perhaps also move it to the test directory?
laanwj commented at 3:49 PM on May 9, 2014: member

See #4159
Move bignum.h to test/ 7cd0af7cc2
sipa commented at 3:57 PM on May 9, 2014: member

@gmaxwell Done. @laanwj Dang, double work :)
laanwj commented at 4:14 PM on May 9, 2014: member

Well you also slimmed bignum.h down, so let's go with this one.
BitcoinPullTester commented at 5:25 PM on May 9, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/7cd0af7cc222d0694ce72e71458aef460698ee2c for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
sipa commented at 12:07 PM on May 10, 2014: member

Alternatively, we could replace the scriptnum tests by data-driven ones, and get rid of bignum.h entirely.
in src/protocol.h:None in 7cd0af7cc2
```
  13 | @@ -14,6 +14,7 @@
  14 |  #include "netbase.h"
  15 |  #include "serialize.h"
  16 |  #include "uint256.h"
  17 | +#include "version.h"
```
Diapolo commented at 1:01 PM on May 10, 2014:

Why is this needed here?

sipa commented at 1:18 PM on May 10, 2014:

Because of CADDR_TIME_VERSION. It was indirectly included through bignum.h.
laanwj commented at 1:31 PM on May 10, 2014: member

Having bignum in the tests directory is fine for now. At some point we could move to data-driven tests, but it seems low-priority as long as we need OpenSSL for other things.
laanwj merged this on May 10, 2014
laanwj closed this on May 10, 2014
laanwj referenced this in commit 2653e00b12 on May 10, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)

#14440 test: Inline scriptnum10 header