osx: Fix missing dock menu with qt5 #4252

pull theuni wants to merge 1 commits into bitcoin:master from theuni:qt5-fix-osx-menu changing 1 files +2 −0

theuni commented at 7:39 PM on May 29, 2014: member

Qt5 Removed the qt_mac_set_dock_menu function and left no replacement.

Qt5.2 adds QMenu::setAsDockMenu() to handle this. Use that when possible. Current Gitian uses Qt5.2, so this fixes release builds.

osx: Fix missing dock menu with qt5

Qt5 Removed the qt_mac_set_dock_menu function and left no replacement. It was
later re-added and deprecated for backwards-compatibility.

Qt5.2 adds the non-deprecated QMenu::setAsDockMenu(). Use that when possible.

c21c74bec4

theuni commented at 8:31 PM on May 29, 2014: member

Heh, I think it's safe to say that's a false positive.
BitcoinPullTester commented at 9:52 PM on May 29, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/c21c74bec43a693283fecbdfb62fee4523317a81 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
gavinandresen commented at 9:53 PM on May 29, 2014: contributor

I had the pull-tester re-test; it was, indeed, a false positive.
theuni commented at 9:59 PM on May 29, 2014: member

Thanks.
laanwj commented at 8:05 AM on May 30, 2014: member

ACK, this should go into 0.9.2 too I suppose?
fanquake commented at 8:08 AM on May 30, 2014: member

ACK

On Friday, May 30, 2014, Wladimir J. van der Laan notifications@github.com wrote:

ACK, this should go into 0.9.2 too I suppose?

Reply to this email directly or view it on GitHub #4252 (comment).
laanwj merged this on May 30, 2014
laanwj closed this on May 30, 2014
laanwj referenced this in commit 97ab93f50b on May 30, 2014
theuni deleted the branch on May 31, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors