Enable customising node policy for datacarrier data size with a -datacarriersize option #5077

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:datacarriersize changing 3 files +8 −2

luke-jr commented at 11:56 PM on October 10, 2014: member

This seems to be something miners want control over.
TheBlueMatt commented at 7:32 AM on October 11, 2014: member

Link/summary to miner requests?
luke-jr commented at 7:53 AM on October 11, 2014: member

The (5-10 people? not big) Eligius tx policy discussion concluded on 80 byte OP_RETURNs, and I've personally observed various positive reactions from random third parties in response, though I didn't save links or anything.
TheBlueMatt commented at 8:18 AM on October 11, 2014: member

What are those third parties? If they are parties using the chain to store data when they could otherwise only store commitments, I'm not sure we want to support them more?
in src/script/standard.cpp:None in 2b404e8598 outdated
```
 136 | @@ -137,7 +137,7 @@ bool Solver(const CScript& scriptPubKey, txnouttype& typeRet, vector<vector<unsi
 137 |              else if (opcode2 == OP_SMALLDATA)
 138 |              {
 139 |                  // small pushdata, <= MAX_OP_RETURN_RELAY bytes
 140 | -                if (vch1.size() > MAX_OP_RETURN_RELAY)
 141 | +                if (vch1.size() > GetArg("-datacarriersize", MAX_OP_RETURN_RELAY))
```
dexX7 commented at 4:36 PM on October 12, 2014:

I'd seperate user input GetArg("-datacarriersize", ...) from actual logic.

laanwj commented at 9:43 AM on October 14, 2014:

Yes I think I mentioned this before to @luke-jr in another pull for another issue. Re-parsing the argument every time this function runs is not a good idea, it should only be done once in AppInit2 or so.

luke-jr commented at 7:58 PM on October 14, 2014:

We're already re-parsing -datacarrier every time too. CNodePolicy would be moving these to AppInit2 anyway.
jgarzik commented at 2:57 PM on October 13, 2014: contributor

PR #5075 updates the logic to default to 80 bytes.
TheBlueMatt commented at 7:45 PM on October 13, 2014: member

@jgarzik Making it an option, sure...changing the default...probably should be discussed on the ML.
Enable customising node policy for datacarrier data size with a -datacarriersize option 2aa632921e
luke-jr force-pushed on Oct 27, 2014
laanwj commented at 10:50 AM on October 27, 2014: member

utACK

TheBlueMatt commented at 8:32 PM on October 28, 2014: member

laanwj merged this on Oct 31, 2014
laanwj closed this on Oct 31, 2014
laanwj referenced this in commit 96012e83f1 on Oct 31, 2014
luke-jr deleted the branch on Jan 1, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Linked (view graph)

#25787 no test coverage for -datacarrier and -datacarriersize