consensus lib work: some win build fixes necessary for dll creation #5081

pull theuni wants to merge 2 commits into bitcoin:master from theuni:fix-dll-creation changing 6 files +20 −11

theuni commented at 7:14 PM on October 13, 2014: member
This is part of the build-system work needed for the upcoming consensus lib.
- Cut down on the dll's linked globally to avoid a few mingw bugs (though it's a legitimate cleanup anyway).
- Split out LIBS for Windows builds as was done for INCLUDES in 6b099402b40dcf9fc716be29c85e7e1865b28e92.
This should result in no noticeable changes.

build: mingw: reduce system linkage to fix mingw dll creation

mingw has trouble linking libssid and libmingwthrd into dll's because they are
missing proper import libs. This may be a bug in a particular version of mingw,
but even if so, it doesn't hurt to clean them up a bit.

libmingwthrd was only used with hardened builds to indirectly provide libssp.
Just use that instead for those builds.

libuuid is only needed for qt, so use it there.

2e5ca7cf06

build: quit abusing LIBS for Windows builds.

Similar to the INCLUDES changes in 6b099402b40, split out LIBS into individual
entries for more fine-grained control.

Also add MINIUPNPC_LIBS which was missing before, and hook it up to
executables.

8981812cda

theuni commented at 8:07 PM on October 13, 2014: member

@TheBlueMatt pointed out some problems here wrt the -lmingwthrd change. It now looks to me like this could've broken exception handling in some cases. Much like https://bitcoin.org/en/alert/2012-03-16-critical-vulnerability . I'm going to work on creating a test-case for this before making any changes.
theuni closed this on Oct 13, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors

theuni

Linked (view graph)

#5086 consensus lib work: some win build fixes necessary for dll creation