consensus lib work: some win build fixes necessary for dll creation #5086

pull theuni wants to merge 2 commits into bitcoin:master from theuni:fix-dll-creation changing 5 files +27 −10

theuni commented at 2:52 AM on October 14, 2014: member
This is a follow-up of #5081. It includes a different fix for the link problem that should be more robust anyway.
- Fix for linking static libs into dll's.
- Split out LIBS for Windows builds as was done for INCLUDES in 6b09940.
This should result in no noticeable changes.

build: quit abusing LIBS for Windows builds.

Similar to the INCLUDES changes in 6b099402b40, split out LIBS into individual
entries for more fine-grained control.

Also add MINIUPNPC_LIBS which was missing before, and hook it up to
executables.

28d412ff20

in configure.ac:None in 5ac15e1d23 outdated
```
  21 | +
  22 | +case $host in
  23 | +  *mingw*)
  24 | +     lt_cv_deplibs_check_method="pass_all"
  25 | +  ;;
  26 | +esac
```
luke-jr commented at 2:55 AM on October 14, 2014:

This looks like a hack. Are there still complications if we use LDFLAGS -no-undefined to tell libtool we don't have undefined symbols in our libraries?

theuni commented at 2:58 AM on October 14, 2014:

-no-undefined has to be there anyway to build a dll.

I could go on a long tirade about this one, it goes several layers deep. Yes, it's a hack, but we're insulated from its down-sides due to the constraints we already enforce.

theuni commented at 7:56 AM on October 14, 2014:

er, that note should say "refuses to link static libs into a dll". Will fix that.
TheBlueMatt commented at 7:49 AM on October 14, 2014: member

utACK
theuni force-pushed on Oct 15, 2014
build: fix libtool's refusal to link static libs into a dll 1723862e82
laanwj merged this on Oct 27, 2014
laanwj closed this on Oct 27, 2014
laanwj referenced this in commit 1bd8a7b2b9 on Oct 27, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors

theuni

luke-jr

TheBlueMatt

Linked (view graph)

#5081 consensus lib work: some win build fixes necessary for dll creation