Related #4993 @theuni As far as I can tell it's only needed in this spot. Test bitcoin_bitcoin-qt seems to run fine.
I'm guessing because
OBJCXXLD qt/bitcoin-qt
CXXLD qt/test/test_bitcoin-qt
Add LIBTOOLFLAGS CXX tag to qt makefile include #5092
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:fix_libtool_link changing 1 files +1 −0-
fanquake commented at 12:05 PM on October 16, 2014: member
-
6f155bdb80
Add LIBTOOLFLAGS CXX tag to qt makefile include
Related #4993
-
theuni commented at 4:40 PM on October 16, 2014: member
ACK. The issue here is that when automake encounters .mm files, it tags the final object as requiring an objective c++ linker. That shouldn't be a problem except that it doesn't communicate well with libtool.
I still haven't dug into where the communication breakdown is. I suspect that either it tells libtool to use the OBJCXX tag which libtool doesn't understand, or that automake itself doesn't have an OBJCXX tag case, so it just skips setting one.
Either way, manually specifying the CXX tag should be perfectly safe.
-
TheBlueMatt commented at 1:38 AM on October 17, 2014: member
utACK
- laanwj merged this on Oct 17, 2014
- laanwj closed this on Oct 17, 2014
- laanwj referenced this in commit 971a3b46a3 on Oct 17, 2014
- fanquake deleted the branch on May 12, 2016
- DrahtBot locked this on Sep 8, 2021
