Add -onion=noproxy for unproxied *.onion connections #5298

1. 
   TheBlueMatt commented at 11:45 pm on November 17, 2014: member

   Kind of ugly hack to pass a fWeAreUsingThisAtConnecTime flag through to LookupIntern which disables the resgular tor-lookup bypass. With this I can successfully connect to *.onion from my machines (which are always behind a VPN which has a *.onion transparent proxy setup).
2. TheBlueMatt force-pushed on Nov 18, 2014
3. TheBlueMatt force-pushed on Nov 18, 2014
4. Add -onion=noproxy for unproxied *.onion connections 46f3e26962
5. TheBlueMatt force-pushed on Nov 18, 2014
6. 
   Diapolo commented at 8:14 am on November 18, 2014: none

   Could you look into this ancient pull (https://github.com/bitcoin/bitcoin/pull/4871) and perhaps check or base this one on mine? Also I’d like to get a more detailed description of what your patch does… I didn’t quite understand everything.
7. 
   sipa commented at 1:28 pm on November 18, 2014: member

   Any reason why you’re not just using fTorNoProxy in LookupIntern?
8. laanwj added the label P2P on Nov 18, 2014
9. 
   TheBlueMatt commented at 9:14 pm on November 18, 2014: member

   @sipa Yea, that breaks unrelated things (eg you end up not sending the right version message as the *.onion is now mapped to a (probably local) IP instead). Also, you would break getpeerinfo.
10. 
    TheBlueMatt commented at 9:16 pm on November 18, 2014: member

    @Diapolo Hmm? It looks like any merge conflicts with that should be cosmetic in nature (ie take no effort to fix). I’d rather keep them separate.
11. 
    Diapolo commented at 9:42 am on November 19, 2014: none

    @TheBlueMatt My intention was to get some review and perhaps discover changed behaviour of my pull, as it seems no one tested it (and I’m missing a testplan yes…).
12. 
    laanwj commented at 10:08 am on November 19, 2014: member

    @diapolo at least the issue is the same here: we don’t have any proxy tests
13. 
    gmaxwell commented at 11:41 am on March 18, 2015: contributor

    Can you convince me that this is really needed? I see it being a pain to maintain and keep secure (e.g. avoid leaks) esp if in the future we get better integration with tor for hidden services, like being able to provide HS keys for dos mitigation.
14. 
    laanwj commented at 12:30 pm on March 19, 2015: member

    NACK. I agree with @gmaxwell and think this complicates the code for a feature I’d expect no one but @thebluematt will use. No tests are provided either, so it could break any time.
15. 
    TheBlueMatt commented at 10:42 am on March 26, 2015: member

    Tests should be written, agreed, but this is incredibly useful for anyone using a tor middlebox. There are several of those around these days, and its not that much code to support a case like that.
16. 
    TheBlueMatt commented at 9:38 am on April 24, 2015: member

    Closing due to the changing-exit-every-time change, as this would be inherintly less anonymous than using the proxy exlicitly thereafter.
17. TheBlueMatt closed this on Apr 24, 2015

    ---

18. MarcoFalke locked this on Sep 8, 2021

Contributors
TheBlueMatt Diapolo sipa laanwj gmaxwell

Labels
P2P