This script updates headers to correct year.
Run through of fix-copyright-headers.py #5519
pull sandakersmann wants to merge 2 commits into bitcoin:master from sandakersmann:master changing 74 files +74 −74-
sandakersmann commented at 7:46 PM on December 20, 2014: contributor
-
6c3eb76730
Run through of fix-copyright-headers.py
This script updates headers to correct year.
-
paveljanik commented at 7:48 PM on December 20, 2014: contributor
What about waiting for 12 days? ;-)
-
02ec4675fc
Correction after running script
Correction after running script
-
sandakersmann commented at 7:52 PM on December 20, 2014: contributor
The script only updates the files that are changed this year. That is why we should merge this before the new year :)
-
Diapolo commented at 11:05 PM on December 20, 2014: none
ACK
-
laanwj commented at 10:17 AM on December 21, 2014: member
NACK, try again in a few months.
I know I just merged #5470 and #5494, but my intention was not to encourage regular mass updates to the headers. An infinite number of these pulls could be generated. I'd prefer waiting with this until well into 2015, as it's especially in the beginning of the year that people forget it.
-
laanwj commented at 10:34 AM on December 21, 2014: member
On a higher level: why do we have years in the copyright headers per file at all?
Git provides an exact history of who contributed what, when. The possibility of a script like this at all shows that is isn't necessary. If we can do it, a law firm can too, in the oft case that it would ever be necessary.
-
petertodd commented at 4:21 PM on December 21, 2014: contributor
@laanwj +1 A good article on the topic is here: http://softwarefreedom.org/resources/2012/ManagingCopyrightInformation.html Their recommended license notice for the "centralized" model of copyright notice is:
This file is part of Foo Project. It is subject to the license terms in the LICENSE file found in the top-level directory of this distribution and at http://www.example.org/foo/license.html. No part of Foo Project, including this file, may be copied, modified, propagated, or distributed except according to the terms contained in the LICENSE file.
You may optionally include a per-file copyright notice with a date, but that's not strictly required given DVCS systems, particularly as we're permissively licensed anyway and don't have contributor agreements.
- laanwj added the label Docs and Output on Dec 22, 2014
-
laanwj commented at 3:33 PM on December 22, 2014: member
So if we remove the years and keep the reference to the LICENSE file that'd be enough. Great! Every bit of micro-management avoided is a win.
-
petertodd commented at 5:12 PM on December 22, 2014: contributor
Who would have thought giving data away with almost no strings attached would be so easy?
On 22 December 2014 10:34:32 GMT-05:00, "Wladimir J. van der Laan" notifications@github.com wrote:
So if we remove the years and keep the reference to the LICENSE file that'd be enough. Great! Every bit of micro-management saved is a win.
Reply to this email directly or view it on GitHub: #5519 (comment)
-
fanquake commented at 6:28 AM on December 26, 2014: member
@petertodd So we should be able to turn this
// Copyright (c) 2010 Satoshi Nakamoto // Copyright (c) 2009-2014 The Bitcoin Core developers // Distributed under the MIT software license, see the accompanying // file COPYING or http://www.opensource.org/licenses/mit-license.php.into just this ?
// Distributed under the MIT software license, see the accompanying // file COPYING or http://www.opensource.org/licenses/mit-license.php. -
sandakersmann commented at 7:23 PM on December 26, 2014: contributor
This would certainly simplify everything. I am all for it :)
-
laanwj commented at 4:36 AM on December 27, 2014: member
I'd say keep the names, remove the dates.
-
jgarzik commented at 5:50 AM on December 27, 2014: contributor
Ask a lawyer rather than guessing. We have plenty of them around the bitcoin space, including working at the Bitcoin Foundation.
-
laanwj commented at 9:46 AM on December 27, 2014: member
Ok, closing this one at least.
- laanwj closed this on Dec 27, 2014
- MarcoFalke locked this on Sep 8, 2021