Make the command-line-args dialog better #5559

zander commented at 11:31 PM on December 28, 2014: none

Instead of using a fixed-width font in a label, which virtually guarantees a horizontal scrollbar, use a proper text-document that can re-layout based on user input.

fanquake commented at 2:59 AM on January 2, 2015: member

Screenshots comparing master & this pull. Note that you've removed the version number from the page. Master screen shot screen shot 1

Pull screen shot 3 screen shot 4

luke-jr commented at 5:15 AM on January 2, 2015: member

I like the idea of spacing between options, but maybe only half a line?

zander commented at 7:03 PM on January 4, 2015: none

Re-added the version number; made the middle lines bold and made the cell-padding less. commandlineoptions

laanwj added the label GUI on Jan 5, 2015

laanwj commented at 8:28 AM on January 5, 2015: member

Certainly looks better. Nit: it's still using a large fixed-width font here. Looks better after removing

ui->helpMessage->setFont(GUIUtil::bitcoinAddressFont());

Make the command-line-args dialog better

Instead of using a fixed-width font in a label, which virtually
guarentees a horizontal scrollbar, use a proper text-document
that can re-layout based on user input.

e179eb3d9b

Diapolo commented at 2:37 PM on January 7, 2015: none

Perhaps we should also remove that graphics to the left then!?

laanwj commented at 8:49 AM on January 8, 2015: member

Hey, that's one of the only leftovers of Satoshi! Anyhow, that doesn't need to be in this pull.

jonasschnelli commented at 8:53 AM on January 8, 2015: contributor

I can take care about the graphic on the left. Needs definitively a replacement (even if its chosen by Satoshi).

laanwj merged this on Jan 8, 2015

laanwj closed this on Jan 8, 2015

laanwj referenced this in commit 83be8fda6d on Jan 8, 2015

jonasschnelli commented at 9:07 AM on January 8, 2015: contributor

Do we need a graphic on this dialogue?

laanwj commented at 9:36 AM on January 8, 2015: member

No.

in src/qt/forms/helpmessagedialog.ui:None in e179eb3d9b

   5 | @@ -6,8 +6,8 @@
   6 |     <rect>
   7 |      <x>0</x>
   8 |      <y>0</y>
   9 | -    <width>800</width>
  10 | -    <height>400</height>
  11 | +    <width>585</width>

Diapolo commented at 10:28 AM on January 8, 2015:

@zander Were this resizes intended?

zander commented at 7:16 PM on January 8, 2015:

yes. Much less content is shown, especially on the 'about' dialog this resize makes sense.

in src/qt/forms/helpmessagedialog.ui:None in e179eb3d9b

  53 | @@ -47,19 +54,22 @@
  54 |           <rect>
  55 |            <x>0</x>
  56 |            <y>0</y>
  57 | -          <width>659</width>
  58 | -          <height>348</height>
  59 | +          <width>447</width>

Diapolo commented at 10:28 AM on January 8, 2015:

@zander Same here...

zander deleted the branch on Jan 8, 2015

jonasschnelli commented at 7:10 PM on January 9, 2015: contributor

Sorry to comment post-merge here. On windows this looks pretty compact: bildschirmfoto 2015-01-09 um 20 08 02

On OSX it's also a bit tiny: bildschirmfoto 2015-01-09 um 20 09 28 1

Is there a reason why this is much smaller then the main window?

MarcoFalke locked this on Sep 8, 2021